Fix generation for already supported image formats #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This would at least partially help #245. |
Bungeefan
changed the title
Owner
|
@Bungeefan this is great. Can you also integrate your change into the Android part of the package? |
Contributor
Author
|
Thanks. |
Owner
|
Oh, yes, you are correct. Thanks! |
|
@jonbhanson @Bungeefan now the package is support GIF ? |
Contributor
Author
|
Yes and no, the package now just converts your GIF file to a PNG, it doesn't animate it or anything. |
|
sad :/ . thanks for replying |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the support for the already supported image formats by the underlying library.
The existing logic of copying the background image has been changed to convert it to PNG and only copy it if it is already ".png".
https://github.com/brendan-duncan/image#supported-image-formats