fix: Prevent empty favorites

Author: jniebuhr

src/display/core/ProfileManager.cpp

@@ -155,7 +155,10 @@ bool ProfileManager::saveProfile(Profile &profile) {
     return ok;
 }
 
-bool ProfileManager::deleteProfile(const String &uuid) { return _fs.remove(profilePath(uuid)); }
+bool ProfileManager::deleteProfile(const String &uuid) {
+    _settings.removeFavoritedProfile(uuid);
+    return _fs.remove(profilePath(uuid));
+}
 
 bool ProfileManager::profileExists(const String &uuid) { return _fs.exists(profilePath(uuid)); }
 
@@ -170,3 +173,13 @@ void ProfileManager::selectProfile(const String &uuid) {
 Profile ProfileManager::getSelectedProfile() const { return selectedProfile; }
 
 void ProfileManager::loadSelectedProfile(Profile &outProfile) { loadProfile(_settings.getSelectedProfile(), outProfile); }
+
+std::vector<String> ProfileManager::getFavoritedProfiles() {
+    std::vector<String> favoritedProfiles;
+    for (String profile : _settings.getFavoritedProfiles()) {
+        if (profileExists(profile)) {
+            favoritedProfiles.push_back(profile);
+        }
+    }
+    return favoritedProfiles;
+}

src/display/core/ProfileManager.h

@@ -20,6 +20,7 @@ class ProfileManager {
     void selectProfile(const String &uuid);
     Profile getSelectedProfile() const;
     void loadSelectedProfile(Profile &outProfile);
+    std::vector<String> getFavoritedProfiles();
 
   private:
     Profile selectedProfile{};

src/display/ui/default/DefaultUI.cpp

@@ -157,7 +157,7 @@ void DefaultUI::changeScreen(lv_obj_t **screen, void (*target_init)()) {
 }
 
 void DefaultUI::onProfileSwitch() {
-    favoritedProfiles = controller->getSettings().getFavoritedProfiles();
+    favoritedProfiles = profileManager->getFavoritedProfiles();
     currentProfileIdx = 0;
     currentProfileId = favoritedProfiles[currentProfileIdx];
     currentProfileChoice = Profile{};