Improve snapshot testing#380
Merged
Merged
Conversation
bdellegrazie
approved these changes
Mar 31, 2026
Collaborator
|
@chadlwilson good to merge this still? |
Collaborator
|
Yup, LGTM. I'll rebase if it breaks any of my PRs, no worries. |
Contributor
Author
|
I hope so, between the current base and |
Vampire
force-pushed
the
improve-snapshot-testing
branch
from
7ca3145 to
4574418
Compare
Contributor
Author
|
I pushed a fresh rebase |
Collaborator
|
(yup, sorry, I meant if any of my PRs conflict after this is merged - although unlikely as don't think I've touched many tests recently in my adjacent PRs) |
Contributor
Author
|
Don't worry, I got you right, rebased anyway :-) |
bdellegrazie
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.