Skip to content

Only test/deploy website if relevant files are changed #6626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 11 commits into from
Jul 5, 2018
Merged

Only test/deploy website if relevant files are changed #6626

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a5ec8eb
Only test/build website if docs/website are changed
endiliey Jul 5, 2018
56dfdd2
Refactor into website.sh
endiliey Jul 5, 2018
234b52b
nits
endiliey Jul 5, 2018
f14584b
chmod executable :)
endiliey Jul 5, 2018
a4de210
add more echo strings
endiliey Jul 5, 2018
36d421b
review
endiliey Jul 5, 2018
6eb2de1
refactor
endiliey Jul 5, 2018
f677baf
fix & nits
endiliey Jul 5, 2018
031b646
rm -rf sleep 5
endiliey Jul 5, 2018
4cb2bc3
update changelog
thymikee Jul 5, 2018
59f955b
Merge branch 'master' into web
thymikee Jul 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 3 additions & 26 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,31 +10,6 @@ aliases:
- node_modules
- website/node_modules
key: v2-dependencies-{{ .Branch }}-{{ checksum "yarn.lock" }}

- &website
command: |
if [[ $CIRCLE_PROJECT_USERNAME == "facebook" && -z $CI_PULL_REQUEST && -z $CIRCLE_PR_USERNAME ]]; then
# configure Docusaurus bot
git config --global user.email "[email protected]"
git config --global user.name "Website Deployment Script"
echo "machine github.com login docusaurus-bot password $DOCUSAURUS_PUBLISH_TOKEN" > ~/.netrc
# install Docusaurus and generate file of English strings
yarn && cd website && yarn write-translations
# crowdin install
sudo apt-get update
sudo apt-get install default-jre rsync
wget https://artifacts.crowdin.com/repo/deb/crowdin.deb -O crowdin.deb
sudo dpkg -i crowdin.deb
sleep 5
# translations upload/download
yarn crowdin-upload
yarn crowdin-download
# build and publish website
GIT_USER=docusaurus-bot USE_SSH=false yarn publish-gh-pages
else
echo "Skipping deploy. Test website build"
cd website && yarn && yarn build
fi

- &filter-ignore-gh-pages
branches:
Expand Down Expand Up @@ -140,7 +115,9 @@ jobs:
- restore-cache: *restore-cache
- run: yarn --no-progress
- save-cache: *save-cache
- run: *website
- run:
name: Test or Deploy Jest Website
command: ./.circleci/website.sh

# Workflows enables us to run multiple jobs in parallel
workflows:
Expand Down
31 changes: 31 additions & 0 deletions .circleci/website.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
#!/bin/bash
Copy link
Member

@SimenB SimenB Jul 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have set -e or something?

Copy link
Contributor Author

@endiliey endiliey Jul 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true. I forget 😢


set -e

FILES_CHANGED=$(git diff-tree --no-commit-id --name-only -r HEAD)
if grep -E "(^docs\/.*)|(^website\/.*)" $FILES_CHANGED; then
echo "Skipping deploy & test. No relevant website files has changed"
Copy link
Member

@rickhanlonii rickhanlonii Jul 5, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the nit but this should be:

No relevant website files have changed

else
if [[ $CIRCLE_PROJECT_USERNAME == "facebook" && -z $CI_PULL_REQUEST && -z $CIRCLE_PR_USERNAME ]]; then
# configure Docusaurus bot
git config --global user.email "[email protected]"
git config --global user.name "Website Deployment Script"
echo "machine github.com login docusaurus-bot password $DOCUSAURUS_PUBLISH_TOKEN" > ~/.netrc
# install Docusaurus and generate file of English strings
yarn && cd website && yarn write-translations
# crowdin install
sudo apt-get update
sudo apt-get install default-jre rsync
wget https://artifacts.crowdin.com/repo/deb/crowdin.deb -O crowdin.deb
sudo dpkg -i crowdin.deb
sleep 5
Copy link
Contributor

@thymikee thymikee Jul 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this sleep still needed?

Copy link
Contributor Author

@endiliey endiliey Jul 5, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tbh i don't think it is needed but I'm just following the previous script. Want to remove ?

Docusaurus use it though
https://github.com/facebook/Docusaurus/blob/3566483aa5fbe0b9cd6988aa14b255f4092ca4c7/.circleci/config.yml#L83

i didn't use it on my test site. Still works flawlessly 😂
https://github.com/endiliey/endiliey.github.io/blob/4c6abe0786e2be11cda2ae7c8d847e957d6ba89d/.travis.yml#L37-L41

Copy link
Contributor

@thymikee thymikee Jul 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kill it

# translations upload/download
yarn crowdin-upload
yarn crowdin-download
# build and publish website
GIT_USER=docusaurus-bot USE_SSH=false yarn publish-gh-pages
else
echo "Skipping deploy. Test website build"
cd website && yarn && yarn build
fi
fi