-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
fix: worker being killed after being spawned and other worker bugs #13107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 52 commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
71d0080
test: ad integration test case for worker not executing test
phawxby 8c6ab73
test: add test case for worker being killed just once
phawxby 86acdf1
fix: worker being killed after spawning
phawxby 718425b
Merge branch 'master' into worker-restart-bug
phawxby de0c0e8
fix: missing license
phawxby d83aa84
fix: flaky tests
phawxby 9435d0b
chore: add some diagnostic logging
phawxby 29e1193
chore: break apart tests to see where the problem is occuring
phawxby c23f581
fix: handling of work ready status
phawxby e8a8058
chore: add fallback timeout
phawxby 4e0b399
refactor: add abstract class with common functions and vars
phawxby 790f772
fix: restarting on init
phawxby b4151ea
refactor: event emitting is a much cleaner way of tracking what's goi…
phawxby 2753069
chore: better handle shutdown events
phawxby 617e102
fix: only set out of memory when necessary
phawxby 28230da
chore: windows debugging
phawxby 60b5b1b
chore: try and debug single test
phawxby a9a3779
chore: remove debugging
phawxby cdf9627
chore: remove logging
phawxby 7a79c92
chore: simplify tests and move more to abstract worker
phawxby 11fd6f8
chore: only run flaky test
phawxby 55f4097
chore: enable tests again
phawxby 723951b
fix: missing snapshot
phawxby a062850
chore: try to resolve the flake
phawxby 66c83bd
chore: logging
phawxby c47404d
chore: see if this changes debugging output
phawxby 9331bd2
chore: make noisy
phawxby 5058e14
chore: debugging
phawxby ddbfb5e
chore: more
phawxby 811e228
chore: even more robust logging
phawxby 197c0da
chore: refactor error streaming monitoring
phawxby 0d0d03e
chore: error handling
phawxby 11e8b25
chore: log this
phawxby 8f427a4
fix: tests and try to detect process crashes differently on windows
phawxby 57d3b20
chore: remove debug logging
phawxby d3abe14
chore: remove only
phawxby f704620
chore: add win32 specific logic to try and work around the issue
phawxby 5a840bb
chore: back to adding debug logging
phawxby d6b2db0
chore: try adding more possible detections
phawxby 202323b
chore: try a different event
phawxby 9e7d081
chore: disconnect handling
phawxby 75037d2
fix: test bug
phawxby 37c5a43
chore: log child and buffer
phawxby 3e8b3ae
chore: forgot to make public
phawxby fab410a
chore: log
phawxby 8e4a31e
chore: use up memory quicker and more logging
phawxby b974eea
chore: try removing force exit to see if that helps with the confusin…
phawxby 1e1023d
chore: different strat
phawxby ab2931d
chore: remove debugging
phawxby c610bdb
chore: revert to silent worker
phawxby ee20013
Update CHANGELOG.md
SimenB bd786b1
chore: pr feedback
phawxby 613fcf2
chore: pr changes
phawxby File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
|
||
| exports[`all 3 test files should complete 1`] = ` | ||
| "Test Suites: 3 passed, 3 total | ||
| Tests: 3 passed, 3 total | ||
| Snapshots: 0 total | ||
| Time: <<REPLACED>> | ||
| Ran all test suites." | ||
| `; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| /** | ||
| * Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| import {extractSummary} from '../Utils'; | ||
| import runJest from '../runJest'; | ||
|
|
||
| it('all 3 test files should complete', () => { | ||
| const result = runJest('worker-restarting'); | ||
| expect(result.exitCode).toBe(0); | ||
| const {summary} = extractSummary(result.stderr); | ||
| expect(summary).toMatchSnapshot(); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| /** | ||
| * Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| test('basic test', () => { | ||
| expect(true).toBeTruthy(); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| /** | ||
| * Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| test('basic test', () => { | ||
| expect(true).toBeTruthy(); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| /** | ||
| * Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| test('basic test', () => { | ||
| expect(true).toBeTruthy(); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "jest": { | ||
| "maxWorkers": 2, | ||
| "workerIdleMemoryLimit": "1MB" | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.