Fix: expect no longer tries to equal non-enumerable symbolic properties.… (#6398)

* `expect` no longer tries to equal non-enumerable symbolic properties. Fixes #6392

* Updated changelog with PR number

* Fixed linting errors

* 'fixed' jest error

Author: mweststrate

CHANGELOG.md

@@ -1,5 +1,9 @@
 ## master
 
+### Fixes
+
+- `[expect]` `toEqual` no longer tries to compare non-enumerable symbolic properties, to be consistent with non-symbolic properties. ([#6398](https://github.com/facebook/jest/pull/6398))
+
 ## 23.1.0
 
 ### Features

packages/expect/src/__tests__/matchers.test.js

@@ -442,6 +442,29 @@ describe('.toEqual()', () => {
       );
     }
   });
+
+  test('non-enumerable members should be skipped during equal', () => {
+    const actual = {
+      x: 3,
+    };
+    Object.defineProperty(actual, 'test', {
+      enumerable: false,
+      value: 5,
+    });
+    expect(actual).toEqual({x: 3});
+  });
+
+  test('non-enumerable symbolic members should be skipped during equal', () => {
+    const actual = {
+      x: 3,
+    };
+    const mySymbol = Symbol('test');
+    Object.defineProperty(actual, mySymbol, {
+      enumerable: false,
+      value: 5,
+    });
+    expect(actual).toEqual({x: 3});
+  });
 });
 
 describe('.toBeInstanceOf()', () => {

packages/expect/src/jasmine_utils.js

@@ -209,7 +209,12 @@ function keys(obj, isArray, hasKey) {
         keys.push(key);
       }
     }
-    return keys.concat((Object.getOwnPropertySymbols(o): Array<any>));
+    return keys.concat(
+      (Object.getOwnPropertySymbols(o): Array<any>).filter(
+        //$FlowFixMe Jest complains about nullability, but we know for sure that property 'symbol' does exist.
+        symbol => Object.getOwnPropertyDescriptor(o, symbol).enumerable,
+      ),
+    );
   })(obj);
 
   if (!isArray) {