Skip to content

Commit 517235a

Browse files
astigefbSimenB
authored andcommitted
Contrib instructs tweaks: Node version, yarn jest (#8671)
1 parent b2c9fe3 commit 517235a

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

CONTRIBUTING.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,12 @@ _Before_ submitting a pull request, please make sure the following is done…
4242
python --version
4343
```
4444

45+
1. Make sure you have a compatible version of `node` installed (As of July 10th 2019, `v10.x` is recommended since there is a known issues with `v12.x` [#8490](https://github.com/facebook/jest/issues/8490)).
46+
47+
```sh
48+
node -v
49+
```
50+
4551
1. Run `yarn install`. On Windows: To install [Yarn](https://yarnpkg.com/en/docs/install#windows-tab) on Windows you may need to download either node.js or Chocolatey<br />
4652

4753
```sh
@@ -69,7 +75,7 @@ _Before_ submitting a pull request, please make sure the following is done…
6975

7076
1. If you've changed APIs, update the documentation.
7177

72-
1. Ensure the test suite passes via `yarn test`. To run the test suite you may need to install [Mercurial](https://www.mercurial-scm.org/) (`hg`). On macOS, this can be done using [homebrew](http://brew.sh/): `brew install hg`.
78+
1. Ensure the test suite passes via `yarn jest`. To run the test suite you may need to install [Mercurial](https://www.mercurial-scm.org/) (`hg`). On macOS, this can be done using [homebrew](http://brew.sh/): `brew install hg`.
7379

7480
```sh-session
7581
$ brew install hg # maybe

0 commit comments

Comments
 (0)