chore: update ts-eslint (#9953)

Author: SimenB

package.json

@@ -18,8 +18,8 @@
     "@types/jest": "24.0.2",
     "@types/node": "*",
     "@types/which": "^1.3.2",
-    "@typescript-eslint/eslint-plugin": "^2.19.0",
-    "@typescript-eslint/parser": "^2.19.0",
+    "@typescript-eslint/eslint-plugin": "^2.30.0",
+    "@typescript-eslint/parser": "^2.30.0",
     "ansi-regex": "^5.0.0",
     "ansi-styles": "^4.2.0",
     "babel-eslint": "^10.0.3",

packages/expect/src/extractExpectedAssertionsErrors.ts

@@ -23,10 +23,16 @@ const resetAssertionsLocalState = () => {
   });
 };
 
+type AssertionsErrors = Array<{
+  actual: string;
+  error: string;
+  expected: string | number;
+}>;
+
 // Create and format all errors related to the mismatched number of `expect`
 // calls and reset the matcher's state.
-const extractExpectedAssertionsErrors = () => {
-  const result = [];
+const extractExpectedAssertionsErrors: () => AssertionsErrors = () => {
+  const result: AssertionsErrors = [];
   const {
     assertionCalls,
     expectedAssertionsNumber,

packages/jest-circus/src/formatNodeAssertErrors.ts

@@ -38,7 +38,10 @@ const humanReadableOperators: Record<string, string> = {
   strictEqual: 'to strictly be equal',
 };
 
-const formatNodeAssertErrors = (event: Circus.Event, state: Circus.State) => {
+const formatNodeAssertErrors = (
+  event: Circus.Event,
+  state: Circus.State,
+): void => {
   if (event.name === 'test_done') {
     event.test.errors = event.test.errors.map((errors: Circus.TestError) => {
       let error;

packages/jest-core/src/lib/active_filters_message.ts

@@ -11,7 +11,7 @@ import type {Config} from '@jest/types';
 const activeFilters = (
   globalConfig: Config.GlobalConfig,
   delimiter: string = '\n',
-) => {
+): string => {
   const {testNamePattern, testPathPattern} = globalConfig;
   if (testNamePattern || testPathPattern) {
     const filters = [

packages/jest-core/src/plugins/quit.ts

@@ -5,7 +5,7 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-import {BaseWatchPlugin} from 'jest-watcher';
+import {BaseWatchPlugin, UsageData} from 'jest-watcher';
 
 class QuitPlugin extends BaseWatchPlugin {
   isInternal: true;
@@ -15,15 +15,15 @@ class QuitPlugin extends BaseWatchPlugin {
     this.isInternal = true;
   }
 
-  async run() {
+  async run(): Promise<void> {
     if (typeof this._stdin.setRawMode === 'function') {
       this._stdin.setRawMode(false);
     }
     this._stdout.write('\n');
     process.exit(0);
   }
 
-  getUsageInfo() {
+  getUsageInfo(): UsageData {
     return {
       key: 'q',
       prompt: 'quit watch mode',

packages/jest-core/src/plugins/test_name_pattern.ts

@@ -6,7 +6,12 @@
  */
 
 import type {Config} from '@jest/types';
-import {BaseWatchPlugin, Prompt, UpdateConfigCallback} from 'jest-watcher';
+import {
+  BaseWatchPlugin,
+  Prompt,
+  UpdateConfigCallback,
+  UsageData,
+} from 'jest-watcher';
 import TestNamePatternPrompt from '../TestNamePatternPrompt';
 import activeFilters from '../lib/active_filters_message';
 
@@ -20,14 +25,14 @@ class TestNamePatternPlugin extends BaseWatchPlugin {
     this.isInternal = true;
   }
 
-  getUsageInfo() {
+  getUsageInfo(): UsageData {
     return {
       key: 't',
       prompt: 'filter by a test name regex pattern',
     };
   }
 
-  onKey(key: string) {
+  onKey(key: string): void {
     this._prompt.put(key);
   }
 

packages/jest-core/src/plugins/test_path_pattern.ts

@@ -6,7 +6,12 @@
  */
 
 import type {Config} from '@jest/types';
-import {BaseWatchPlugin, Prompt, UpdateConfigCallback} from 'jest-watcher';
+import {
+  BaseWatchPlugin,
+  Prompt,
+  UpdateConfigCallback,
+  UsageData,
+} from 'jest-watcher';
 import TestPathPatternPrompt from '../TestPathPatternPrompt';
 import activeFilters from '../lib/active_filters_message';
 
@@ -20,14 +25,14 @@ class TestPathPatternPlugin extends BaseWatchPlugin {
     this.isInternal = true;
   }
 
-  getUsageInfo() {
+  getUsageInfo(): UsageData {
     return {
       key: 'p',
       prompt: 'filter by a filename regex pattern',
     };
   }
 
-  onKey(key: string) {
+  onKey(key: string): void {
     this._prompt.put(key);
   }
 

packages/jest-core/src/plugins/update_snapshots.ts

@@ -10,6 +10,7 @@ import {
   BaseWatchPlugin,
   JestHookSubscriber,
   UpdateConfigCallback,
+  UsageData,
 } from 'jest-watcher';
 
 class UpdateSnapshotsPlugin extends BaseWatchPlugin {
@@ -30,13 +31,13 @@ class UpdateSnapshotsPlugin extends BaseWatchPlugin {
     return Promise.resolve(false);
   }
 
-  apply(hooks: JestHookSubscriber) {
+  apply(hooks: JestHookSubscriber): void {
     hooks.onTestRunComplete(results => {
       this._hasSnapshotFailure = results.snapshot.failure;
     });
   }
 
-  getUsageInfo() {
+  getUsageInfo(): UsageData | null {
     if (this._hasSnapshotFailure) {
       return {
         key: 'u',

packages/jest-core/src/plugins/update_snapshots_interactive.ts

@@ -7,7 +7,7 @@
 
 import type {Config} from '@jest/types';
 import type {AggregatedResult, AssertionLocation} from '@jest/test-result';
-import {BaseWatchPlugin, JestHookSubscriber} from 'jest-watcher';
+import {BaseWatchPlugin, JestHookSubscriber, UsageData} from 'jest-watcher';
 import SnapshotInteractiveMode from '../SnapshotInteractiveMode';
 
 class UpdateSnapshotInteractivePlugin extends BaseWatchPlugin {
@@ -41,7 +41,7 @@ class UpdateSnapshotInteractivePlugin extends BaseWatchPlugin {
     return failedTestPaths;
   }
 
-  apply(hooks: JestHookSubscriber) {
+  apply(hooks: JestHookSubscriber): void {
     hooks.onTestRunComplete(results => {
       this._failedSnapshotTestAssertions = this.getFailedSnapshotTestAssertions(
         results,
@@ -52,7 +52,7 @@ class UpdateSnapshotInteractivePlugin extends BaseWatchPlugin {
     });
   }
 
-  onKey(key: string) {
+  onKey(key: string): void {
     if (this._snapshotInteractiveMode.isActive()) {
       this._snapshotInteractiveMode.put(key);
     }
@@ -85,11 +85,8 @@ class UpdateSnapshotInteractivePlugin extends BaseWatchPlugin {
     }
   }
 
-  getUsageInfo() {
-    if (
-      this._failedSnapshotTestAssertions &&
-      this._failedSnapshotTestAssertions.length > 0
-    ) {
+  getUsageInfo(): UsageData | null {
+    if (this._failedSnapshotTestAssertions?.length > 0) {
       return {
         key: 'i',
         prompt: 'update failing snapshots interactively',

packages/jest-diff/src/index.ts

@@ -50,6 +50,7 @@ const FALLBACK_FORMAT_OPTIONS_0 = {...FALLBACK_FORMAT_OPTIONS, indent: 0};
 
 // Generate a string that will highlight the difference between two values
 // with green and red. (similar to how github does code diffing)
+// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
 function diff(a: any, b: any, options?: DiffOptions): string | null {
   if (Object.is(a, b)) {
     return NO_DIFF_MESSAGE;