Skip to content

Conversation

@connectdotz
Copy link
Collaborator

Resolves #1209

When the test branch contains both resolved and unresolved test names in its parent chain, the current "shallow" test name validation might mistakenly consider it "resolved". This PR changes the validation to perform a deep lookup: only returning the node whose parent nodes are all resolved for a test run. If the root test block of the given test file is unresolved, the whole test file will be run instead.

@connectdotz connectdotz requested a review from Copilot April 4, 2025 21:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/test-provider/test-item-data.ts:117

  • Consider adding unit tests to cover the error handling branch when no process is available in scheduleTest.
throw new Error(`failed to schedule test for ${this.item.id}`);

@coveralls
Copy link

Pull Request Test Coverage Report for Build 14274644143

Details

  • 24 of 24 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 98.185%

Totals Coverage Status
Change from base Build 14252604180: 0.005%
Covered Lines: 4113
Relevant Lines: 4119

💛 - Coveralls

@connectdotz connectdotz merged commit 03f5282 into jest-community:master Apr 4, 2025
11 checks passed
@connectdotz connectdotz deleted the deep-test-name-pattern-lookup branch April 4, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Can't run test multiple times

2 participants