Skip to content

docs: update README.md fix jest run mode type #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2024
Merged

docs: update README.md fix jest run mode type #1126

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a770381
Update README.md
kota-kamikawa Mar 12, 2024
7b897a2
docs: delete revealOutput from README.md
kota-kamikawa Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ The following are the predefined `runMode` configurations for convenience. They
|Predefined runMode|Description|JestRunMode|
|:---:|---|---|
|"watch"| run tests by watchman | {type: "watch", revealOutput: "on-run"} |
Copy link
Collaborator

@connectdotz connectdotz Mar 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for bringing this to our attention. It turns out this section has even more outdated information😓: there is no longer a revealOutput attribute. Would you mind removing all the revalOutput as well while you are at it? Thanks!

Copy link
Contributor Author

@kota-kamikawa kota-kamikawa Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@connectdotz
Thank you for the review, I have deleted it!

docs: delete revealOutput from README.md

|"on-save"| run tests when test or source files are saved|{type: "on-run", revealOutput: "on-run"}|
|"on-save"| run tests when test or source files are saved|{type: "on-save", revealOutput: "on-run"}|
|"on-demand"|run tests on-demand through UI | {type: "on-demand", revealOutput: "on-run"} |
|"deferred"|defer test run and discovery until the first on-demand run | {type: "on-demand", revealOutput: "on-run", deferred: true } |

Expand Down