Skip to content

Conversation

@kota-kamikawa
Copy link
Contributor

@kota-kamikawa kota-kamikawa commented Mar 12, 2024

I've updated following section of the README file. Please review it!

スクリーンショット 2024-03-12 10 37 57

chore: fix jest run mode type
@kota-kamikawa kota-kamikawa changed the title Update README.md Fix Jest Run Mode Type docs: Update README.md Fix Jest Run Mode Type Mar 12, 2024
@kota-kamikawa kota-kamikawa changed the title docs: Update README.md Fix Jest Run Mode Type docs: update README.md fix jest run mode type Mar 12, 2024
Copy link
Collaborator

@connectdotz connectdotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

README.md Outdated

|Predefined runMode|Description|JestRunMode|
|:---:|---|---|
|"watch"| run tests by watchman | {type: "watch", revealOutput: "on-run"} |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for bringing this to our attention. It turns out this section has even more outdated information😓: there is no longer a revealOutput attribute. Would you mind removing all the revalOutput as well while you are at it? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@connectdotz
Thank you for the review, I have deleted it!

docs: delete revealOutput from README.md

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8258769281

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.998%

Totals Coverage Status
Change from base Build 8011512317: 0.0%
Covered Lines: 3919
Relevant Lines: 3926

💛 - Coveralls

@connectdotz connectdotz merged commit cd80572 into jest-community:master Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants