Skip to content

Upgrade to Babel 7 #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SimenB merged 2 commits into from
Jul 9, 2021
Merged

Upgrade to Babel 7 #327

SimenB merged 2 commits into from
Jul 9, 2021

Conversation

@keeganwitt
Copy link
Collaborator

@keeganwitt keeganwitt commented Jun 23, 2021

What

Upgrade to Babel 7.

SimenB
SimenB reviewed Jun 23, 2021
View reviewed changes
SimenB
SimenB reviewed Jun 23, 2021
View reviewed changes
package.json
"@babel/preset-env",
{
"targets": {
"node": "12"
Copy link
Member

@SimenB SimenB Jun 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should target whatever is the lowest this library supports - node 8 from the looks of

jest-extended/.travis.yml

Line 3 in 437d55a

- '8'

Copy link
Collaborator Author

@keeganwitt keeganwitt Jun 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that still the case? I think that file hasn't been updated in a while. What does Jest support?

Copy link
Member

@SimenB SimenB Jun 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jest 26 and 27 supports node 10, but I'm fine with only supporting 12 and later here as 10 is EOL

@keeganwitt
Copy link
Collaborator Author

keeganwitt commented Jun 23, 2021 •
edited
Loading

I suspect the failures are because the current version of ESLint doesn't play nice with the upgraded version of @babel/eslint-parser. Once we merge #328, I'll rebase and look again at these failures.

Update: confirmed this locally.

@keeganwitt keeganwitt mentioned this pull request Jun 28, 2021
Merged
4 tasks
@keeganwitt
Copy link
Collaborator Author

keeganwitt commented Jun 30, 2021

I went ahead and added the lint fixes to this branch so it can be merged independently.

@SimenB SimenB mentioned this pull request Jul 4, 2021
Closed
4 tasks
@SimenB SimenB merged commit 671bbdd into jest-community:master Jul 9, 2021
@keeganwitt keeganwitt deleted the upstream/keeganwitt/babel_7 branch July 9, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SimenB SimenB SimenB left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@keeganwitt @SimenB