feat(prefer-mock-return-shorthand): greatly improve checking if mutable variables are used#1914
Merged
feat(prefer-mock-return-shorthand): greatly improve checking if mutable variables are used#1914
Conversation
github-actions bot
pushed a commit
that referenced
this pull request
Dec 30, 2025
# [29.12.0](v29.11.4...v29.12.0) (2025-12-30) ### Features * **prefer-mock-return-shorthand:** greatly improve checking if mutable variables are used ([#1914](#1914)) ([13bbd20](13bbd20))
|
🎉 This PR is included in version 29.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1907 (again, mostly)
I'm pretty sure this is just about everything, though I expect there are still some edge cases where the rule still isn't actually safe, but hopefully there should be a lot less of them now.
We still currently treat objects as immuable which is technically unsafe but I think should be pretty reasonable since public object mutation is usually a bad idea - we can explore changing that later (either by default or via an option) based on how much feedback we get from users.
This should also be applied to
prefer-mock-promise-shorthandas well, which I'll do "later"