Skip to content

Commit 91c2589

Browse files
committed
Fix ambiguous assert_eq import
1 parent 81251f1 commit 91c2589

14 files changed

+137
-126
lines changed

src/structures/000_bios.rs

Lines changed: 33 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,7 @@ impl fmt::Display for FirmwareRevision {
357357
mod tests {
358358
use std::{prelude::v1::*, sync::OnceLock};
359359

360-
use pretty_assertions::assert_eq;
360+
use pretty_assertions::assert_eq as pretty_assert_eq;
361361

362362
use super::*;
363363
use crate::bitfield::Position;
@@ -378,20 +378,22 @@ mod tests {
378378
.iter()
379379
.filter_map(|f| if f.is_set { Some(*f.position) } else { None })
380380
.collect::<Vec<_>>();
381-
assert_eq!(sample, result, "Positions");
381+
pretty_assert_eq!(sample, result, "Positions");
382382

383383
let sample = vec!["ISA is supported", "EISA is supported"];
384384
let qword = 0b0101_0000;
385385
let iter = Characteristics(qword).significants();
386386
let result = iter.map(|f| format!("{f}")).collect::<Vec<_>>();
387-
assert_eq!(
388-
sample, result,
387+
pretty_assert_eq!(
388+
sample,
389+
result,
389390
"Significant values, default formatting ({:064b})",
390391
qword
391392
);
392393
let result = iter.map(|f| format!("{f:#}")).collect::<Vec<_>>();
393-
assert_eq!(
394-
sample, result,
394+
pretty_assert_eq!(
395+
sample,
396+
result,
395397
"Significant values, alternative formatting ({:064b})",
396398
qword
397399
);
@@ -404,7 +406,7 @@ mod tests {
404406
.reserved()
405407
.map(|v| (v.description, v.range))
406408
.collect::<Vec<_>>();
407-
assert_eq!(sample, result, "Reserved fields");
409+
pretty_assert_eq!(sample, result, "Reserved fields");
408410
}
409411
#[test]
410412
fn characteristics_extension1() {
@@ -414,27 +416,29 @@ mod tests {
414416
.iter()
415417
.filter_map(|f| if f.is_set { Some(*f.position) } else { None })
416418
.collect::<Vec<_>>();
417-
assert_eq!(sample, result, "Positions");
419+
pretty_assert_eq!(sample, result, "Positions");
418420

419421
let dflt_sample = vec!["ACPI is supported", "IEEE 1394 boot is supported"];
420422
let alt_sample = vec!["ACPI is supported", "1394 boot is supported"];
421423
let byte = 0b0100_0001;
422424
let iter = CharacteristicsExtension1(byte).significants();
423425
let dflt_result = iter.map(|f| format!("{f}")).collect::<Vec<_>>();
424-
assert_eq!(
425-
dflt_sample, dflt_result,
426+
pretty_assert_eq!(
427+
dflt_sample,
428+
dflt_result,
426429
"Significant values, default formatting ({:08b})",
427430
byte
428431
);
429432
let alt_result = iter.map(|f| format!("{f:#}")).collect::<Vec<_>>();
430-
assert_eq!(
431-
alt_sample, alt_result,
433+
pretty_assert_eq!(
434+
alt_sample,
435+
alt_result,
432436
"Significant values, alternative formatting ({:08b})",
433437
byte
434438
);
435439

436440
let result = CharacteristicsExtension1(0).reserved().count();
437-
assert_eq!(0, result, "Reserved fields");
441+
pretty_assert_eq!(0, result, "Reserved fields");
438442
}
439443
#[test]
440444
fn characteristics_extension2() {
@@ -444,21 +448,23 @@ mod tests {
444448
.iter()
445449
.filter_map(|f| if f.is_set { Some(*f.position) } else { None })
446450
.collect::<Vec<_>>();
447-
assert_eq!(sample, result, "Positions");
451+
pretty_assert_eq!(sample, result, "Positions");
448452

449453
let short_sample = vec!["UEFI is supported", "System is a virtual machine"];
450454
let long_sample = vec!["UEFI is supported","SMBIOS table describes a virtual machine. (If this bit is not set, no inference can be made about the virtuality of the system.)"];
451455
let byte = 0b0001_1000;
452456
let iter = CharacteristicsExtension2(byte).significants();
453457
let result = iter.map(|f| format!("{f}")).collect::<Vec<_>>();
454-
assert_eq!(
455-
short_sample, result,
458+
pretty_assert_eq!(
459+
short_sample,
460+
result,
456461
"Significant values, default formatting ({:08b})",
457462
byte
458463
);
459464
let result = iter.map(|f| format!("{f:#}")).collect::<Vec<_>>();
460-
assert_eq!(
461-
long_sample, result,
465+
pretty_assert_eq!(
466+
long_sample,
467+
result,
462468
"Significant values, alternative formatting ({:08b})",
463469
byte
464470
);
@@ -468,7 +474,7 @@ mod tests {
468474
.reserved()
469475
.map(|v| (v.description, v.range))
470476
.collect::<Vec<_>>();
471-
assert_eq!(sample, result, "Reserved fields");
477+
pretty_assert_eq!(sample, result, "Reserved fields");
472478
}
473479
#[test]
474480
fn rom_size() {
@@ -490,7 +496,7 @@ mod tests {
490496
.into()
491497
})
492498
.collect();
493-
assert_eq!(sample, result, "ROM Size");
499+
pretty_assert_eq!(sample, result, "ROM Size");
494500
}
495501
#[test]
496502
fn dmi_bin_full_bios_structure() {
@@ -553,7 +559,7 @@ mod tests {
553559
}
554560
})
555561
.unwrap();
556-
assert_eq!(bios_sample, bios_result, "Full BIOS Struct");
562+
pretty_assert_eq!(bios_sample, bios_result, "Full BIOS Struct");
557563
}
558564

559565
#[test]
@@ -598,8 +604,9 @@ mod tests {
598604
.chain(bios_result.bios_characteristics_exttension_2.unwrap().significants())
599605
.map(|v| format!("{v}"))
600606
.collect::<Vec<_>>();
601-
assert_eq!(
602-
all_characteristics_sample, all_char_result,
607+
pretty_assert_eq!(
608+
all_characteristics_sample,
609+
all_char_result,
603610
"Characteristics as in dmidecode tool"
604611
);
605612
}
@@ -618,12 +625,12 @@ mod tests {
618625
}
619626
})
620627
.unwrap();
621-
assert_eq!(
628+
pretty_assert_eq!(
622629
bios_revision,
623630
format!("{}", bios_result.bios_revision.unwrap()),
624631
"BIOS Revision"
625632
);
626-
assert_eq!(
633+
pretty_assert_eq!(
627634
firmware_revision,
628635
format!("{}", bios_result.firmware_revision.unwrap()),
629636
"Firmware Revision"
@@ -643,6 +650,6 @@ mod tests {
643650
}
644651
})
645652
.unwrap();
646-
assert_eq!(size, bios_result.rom_size.into(), "ROM BIOS size");
653+
pretty_assert_eq!(size, bios_result.rom_size.into(), "ROM BIOS size");
647654
}
648655
}

src/structures/008_port_connector.rs

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ impl fmt::Display for PortType {
343343

344344
#[cfg(test)]
345345
mod test {
346-
use pretty_assertions::assert_eq;
346+
use pretty_assertions::assert_eq as pretty_assert_eq;
347347
use std::prelude::v1::*;
348348
#[test]
349349
fn connector_type() {
@@ -360,7 +360,7 @@ mod test {
360360
),
361361
];
362362
let result = samples.iter().map(|v| Into::into(v.0)).collect::<Vec<_>>();
363-
assert_eq!(
363+
pretty_assert_eq!(
364364
samples.iter().map(|(_, v, s)| (v, (*s).into())).collect::<Vec<_>>(),
365365
result.iter().map(|r| (r, format!("{r}"))).collect::<Vec<_>>(),
366366
);
@@ -376,7 +376,7 @@ mod test {
376376
(0xFE, PortType::Undefined(254), "Undefined: 254"),
377377
];
378378
let result = samples.iter().map(|v| Into::into(v.0)).collect::<Vec<_>>();
379-
assert_eq!(
379+
pretty_assert_eq!(
380380
samples.iter().map(|(_, v, s)| (v, (*s).into())).collect::<Vec<_>>(),
381381
result.iter().map(|r| (r, format!("{r}"))).collect::<Vec<_>>(),
382382
);
@@ -407,7 +407,7 @@ mod test {
407407
],
408408
};
409409
let result = PortConnector::try_from(structure).unwrap();
410-
assert_eq!(sample, result);
410+
pretty_assert_eq!(sample, result);
411411
}
412412
#[test]
413413
fn dmi_bin() {
@@ -435,18 +435,18 @@ mod test {
435435
_ => None,
436436
})
437437
.unwrap();
438-
assert_eq!(&usb_sample, usb_result, "USB");
439-
assert_eq!(
438+
pretty_assert_eq!(&usb_sample, usb_result, "USB");
439+
pretty_assert_eq!(
440440
"Access Bus (USB)",
441441
format!("{}", usb_result.internal_connector_type),
442442
"USB: Internal Connector Type"
443443
);
444-
assert_eq!(
444+
pretty_assert_eq!(
445445
"None",
446446
format!("{}", usb_result.external_connector_type),
447447
"USB: External Connector Type"
448448
);
449-
assert_eq!("USB", format!("{}", usb_result.port_type), "USB: Port Type");
449+
pretty_assert_eq!("USB", format!("{}", usb_result.port_type), "USB: Port Type");
450450

451451
let rj45_sample = PortConnector {
452452
handle: 0x080A,
@@ -463,17 +463,17 @@ mod test {
463463
_ => None,
464464
})
465465
.unwrap();
466-
assert_eq!(&rj45_sample, rj45_result, "RJ-45");
467-
assert_eq!(
466+
pretty_assert_eq!(&rj45_sample, rj45_result, "RJ-45");
467+
pretty_assert_eq!(
468468
"None",
469469
format!("{}", rj45_result.internal_connector_type),
470470
"RJ-45: Internal Connector Type"
471471
);
472-
assert_eq!(
472+
pretty_assert_eq!(
473473
"RJ-45",
474474
format!("{}", rj45_result.external_connector_type),
475475
"RJ-45: External Connector Type"
476476
);
477-
assert_eq!("Network Port", format!("{}", rj45_result.port_type), "RJ-45: Port Type");
477+
pretty_assert_eq!("Network Port", format!("{}", rj45_result.port_type), "RJ-45: Port Type");
478478
}
479479
}

0 commit comments

Comments
 (0)