Add suppressions for 8500

Julien Couvreur · Julien Couvreur · commit a78886ff4855 · 2022-09-15T15:42:29.000-07:00
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -277,7 +277,7 @@
     <RuntimeIdGraphDefinitionFile>$([MSBuild]::NormalizePath('$(LibrariesProjectRoot)', 'Microsoft.NETCore.Platforms', 'src', 'runtime.json'))</RuntimeIdGraphDefinitionFile>
     <LicenseFile>$(MSBuildThisFileDirectory)LICENSE.TXT</LicenseFile>
 
-    <RestoreAdditionalProjectSources>d:\repos\roslyn\artifacts\packages\Debug\Shipping\</RestoreAdditionalProjectSources>
+    <RestoreAdditionalProjectSources>d:\repos\roslyn\artifacts\packages\Release\Shipping\</RestoreAdditionalProjectSources>
 
     <PackageLicenseExpression>MIT</PackageLicenseExpression>
     <PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance>
diff --git a/src/coreclr/System.Private.CoreLib/src/System/Reflection/Emit/DynamicMethod.cs b/src/coreclr/System.Private.CoreLib/src/System/Reflection/Emit/DynamicMethod.cs
@@ -504,7 +504,9 @@ Signature LazyCreateSignature()
                     Span<ParameterCopyBackAction> shouldCopyBackParameters = new(ref argStorage._copyBack0, argCount);
 
                     StackAllocatedByRefs byrefStorage = default;
+#pragma warning disable 8500
                     IntPtr* pByRefStorage = (IntPtr*)&byrefStorage;
+#pragma warning restore 8500
 
                     CheckArguments(
                         copyOfParameters,
diff --git a/src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.CoreCLR.cs b/src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.CoreCLR.cs
@@ -316,7 +316,9 @@ public override MethodImplAttributes GetMethodImplementationFlags()
                 Span<ParameterCopyBackAction> shouldCopyBackParameters = new(ref argStorage._copyBack0, 1);
 
                 StackAllocatedByRefs byrefStorage = default;
+#pragma warning disable 8500
                 IntPtr* pByRefStorage = (IntPtr*)&byrefStorage;
+#pragma warning restore 8500
 
                 CheckArguments(
                     copyOfParameters,
diff --git a/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodBase.cs b/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodBase.cs
@@ -247,12 +247,16 @@ BindingFlags invokeAttr
                         ((sigType.IsEnum || arg.GetType().IsEnum) && RuntimeType.GetUnderlyingType((RuntimeType)arg.GetType()) == RuntimeType.GetUnderlyingType(sigType)));
 #endif
                     ByReference valueTypeRef = ByReference.Create(ref copyOfParameters[i]!.GetRawData());
+#pragma warning disable 8500
                     *(ByReference*)(byrefParameters + i) = valueTypeRef;
+#pragma warning restore 8500
                 }
                 else
                 {
                     ByReference objRef = ByReference.Create(ref copyOfParameters[i]);
+#pragma warning disable 8500
                     *(ByReference*)(byrefParameters + i) = objRef;
+#pragma warning restore 8500
                 }
             }
         }
diff --git a/src/libraries/System.Private.CoreLib/src/System/Reflection/RuntimeConstructorInfo.cs b/src/libraries/System.Private.CoreLib/src/System/Reflection/RuntimeConstructorInfo.cs
@@ -146,7 +146,9 @@ internal void ThrowNoInvokeException()
                     Span<ParameterCopyBackAction> shouldCopyBackParameters = new(ref argStorage._copyBack0, argCount);
 
                     StackAllocatedByRefs byrefStorage = default;
+#pragma warning disable 8500
                     IntPtr* pByRefStorage = (IntPtr*)&byrefStorage;
+#pragma warning restore 8500
 
                     CheckArguments(
                         copyOfParameters,
@@ -299,7 +301,9 @@ public override object Invoke(BindingFlags invokeAttr, Binder? binder, object?[]
                     Span<ParameterCopyBackAction> shouldCopyBackParameters = new(ref argStorage._copyBack0, argCount);
 
                     StackAllocatedByRefs byrefStorage = default;
+#pragma warning disable 8500
                     IntPtr* pByRefStorage = (IntPtr*)&byrefStorage;
+#pragma warning restore 8500
 
                     CheckArguments(
                         copyOfParameters,
diff --git a/src/libraries/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs b/src/libraries/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs
@@ -143,7 +143,9 @@ private void ThrowNoInvokeException()
                     Span<ParameterCopyBackAction> shouldCopyBackParameters = new(ref argStorage._copyBack0, argCount);
 
                     StackAllocatedByRefs byrefStorage = default;
+#pragma warning disable 8500
                     IntPtr* pByRefStorage = (IntPtr*)&byrefStorage;
+#pragma warning restore 8500
 
                     CheckArguments(
                         copyOfParameters,

Original file line number	Diff line number	Diff line change
`@@ -247,12 +247,16 @@ BindingFlags invokeAttr`
`247`	`247`	`((sigType.IsEnum \|\| arg.GetType().IsEnum) && RuntimeType.GetUnderlyingType((RuntimeType)arg.GetType()) == RuntimeType.GetUnderlyingType(sigType)));`
`248`	`248`	`#endif`
`249`	`249`	`ByReference valueTypeRef = ByReference.Create(ref copyOfParameters[i]!.GetRawData());`
	`250`	`+#pragma warning disable 8500`
`250`	`251`	`(ByReference)(byrefParameters + i) = valueTypeRef;`
	`252`	`+#pragma warning restore 8500`
`251`	`253`	`}`
`252`	`254`	`else`
`253`	`255`	`{`
`254`	`256`	`ByReference objRef = ByReference.Create(ref copyOfParameters[i]);`
	`257`	`+#pragma warning disable 8500`
`255`	`258`	`(ByReference)(byrefParameters + i) = objRef;`
	`259`	`+#pragma warning restore 8500`
`256`	`260`	`}`
`257`	`261`	`}`
`258`	`262`	`}`