Skip to content

Fix MdbWriter to produce the correct MVID in case deterministic output is required - #681

Merged
jbevain merged 1 commit into
jbevain:masterfrom
vitek-karas:MdbWriterDeterministicMVID
Jul 21, 2020
Merged

jbevain merged 1 commit into
jbevain:masterfrom
vitek-karas:MdbWriterDeterministicMVID

Conversation

@vitek-karas

Copy link
Copy Markdown
Contributor

Fixes #680.

The MdbWriter must not cache the MVID upon writer construction, but it needs to get it only after it was computed - so basically only when it's about to actually write.

…t is required

This is a fix for jbevain#680.

The MdbWriter must not cache the MVID upon writer construction, but it needs to get it only after it was computed - so basically only when it's about to actually write.
@jbevain

jbevain commented Jul 21, 2020

Copy link
Copy Markdown
Owner

Thank you!

mrvoorhe pushed a commit to Unity-Technologies/cecil that referenced this pull request Oct 14, 2020
…t is required (jbevain#681)

This is a fix for jbevain#680.

The MdbWriter must not cache the MVID upon writer construction, but it needs to get it only after it was computed - so basically only when it's about to actually write.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MdbWriter doesn't write the correct MVID when using deterministic MVID

2 participants