comment-out PyArray_TypeNumFromName

Author: jakevdp

ml_dtypes/_src/custom_float.h

@@ -878,22 +878,26 @@ bool RegisterFloatDtype(PyObject* numpy, bool* already_registered = nullptr) {
   // writing is this one (distributed in TF and JAX).
   // TODO(phawkins): distribute the bfloat16 extension as its own pip package,
   // so we can unambiguously refer to a single canonical definition of bfloat16.
-  int typenum =
-      PyArray_TypeNumFromName(const_cast<char*>(TypeDescriptor<T>::kTypeName));
-  if (typenum != NPY_NOTYPE) {
-    PyArray_Descr* descr = PyArray_DescrFromType(typenum);
-    // The test for an argmax function here is to verify that the
-    // bfloat16 implementation is sufficiently new, and, say, not from
-    // an older version of TF or JAX.
-    if (descr && descr->f && descr->f->argmax) {
-      TypeDescriptor<T>::npy_type = typenum;
-      TypeDescriptor<T>::type_ptr = reinterpret_cast<PyObject*>(descr->typeobj);
-      if (already_registered != nullptr) {
-        *already_registered = true;
-      }
-      return true;
-    }
-  }
+
+  // TODO(jakevdp): comment this out for now to enable testing against numpy upstream.
+  // We should NOT merge before uncommenting this.
+
+  // int typenum =
+  //     PyArray_TypeNumFromName(const_cast<char*>(TypeDescriptor<T>::kTypeName));
+  // if (typenum != NPY_NOTYPE) {
+  //   PyArray_Descr* descr = PyArray_DescrFromType(typenum);
+  //   // The test for an argmax function here is to verify that the
+  //   // bfloat16 implementation is sufficiently new, and, say, not from
+  //   // an older version of TF or JAX.
+  //   if (descr && descr->f && descr->f->argmax) {
+  //     TypeDescriptor<T>::npy_type = typenum;
+  //     TypeDescriptor<T>::type_ptr = reinterpret_cast<PyObject*>(descr->typeobj);
+  //     if (already_registered != nullptr) {
+  //       *already_registered = true;
+  //     }
+  //     return true;
+  //   }
+  // }
 
   // It's important that we heap-allocate our type. This is because tp_name
   // is not a fully-qualified name for a heap-allocated type, and