Fix RemoteAttacher date filtering to preserve time component

Remove CAST to Date which was stripping time component and causing
timezone-sensitive test failures in RemoteDatabaseAttacherTests.

Issue:
- SqlHistoricalDataFilter was using CAST(column as Date)
- This strips hours/minutes/seconds from datetime values
- When test runs near midnight, causes off-by-one day errors
- Test expects 3 rows but gets 2 due to date boundary issues

Example failure:
- withinDate = "2025-10-28 23:00:00" (1 hour ago, Oct 28)
- CAST to Date = "2025-10-28" (time stripped)
- DATEADD(DAY, -1, GETDATE()) = "2025-10-28" at midnight
- Comparison: "2025-10-28" > "2025-10-28" = FALSE (row excluded)

Fix:
- Remove all CAST(column as Date) operations
- Use datetime column directly for time-sensitive comparisons
- Preserves full precision for accurate date filtering

Affected cases:
- Past24Hours, Past7Days, PastMonth, PastYear
- SinceLastUse, Custom, DeltaReading

This fixes CI failures in PR #39 and other dependabot PRs running
RemoteDatabaseAttacherTests at various times of day.

Tests affected:
- TestRemoteDatabaseAttacherWithDateFilter(*, *, Past24Hours)

Author: jas88

Rdmp.Core/DataLoad/Modules/Attachers/RemoteAttacher.cs

@@ -104,31 +104,32 @@ private string ConvertDateString(DatabaseType dbType, string dateString)
 
     public string SqlHistoricalDataFilter(ILoadMetadata loadMetadata, DatabaseType dbType, string column)
     {
-        const string dateConvert = "Date";
+        // Don't cast to Date - preserve time component for accurate filtering
+        // Casting to Date causes timezone-sensitive failures when time crosses midnight
 
         switch (HistoricalFetchDuration)
         {
             case AttacherHistoricalDurations.Past24Hours:
-                return $" WHERE CAST({column} as {dateConvert}) > {GetCorrectDateAddForDatabaseType(dbType, "DAY", "-1")}";
+                return $" WHERE {column} > {GetCorrectDateAddForDatabaseType(dbType, "DAY", "-1")}";
             case AttacherHistoricalDurations.Past7Days:
-                return $" WHERE CAST({column} as {dateConvert}) > {GetCorrectDateAddForDatabaseType(dbType, "WEEK", "-1")}";
+                return $" WHERE {column} > {GetCorrectDateAddForDatabaseType(dbType, "WEEK", "-1")}";
             case AttacherHistoricalDurations.PastMonth:
-                return $" WHERE CAST({column} as {dateConvert}) > {GetCorrectDateAddForDatabaseType(dbType, "MONTH", "-1")}";
+                return $" WHERE {column} > {GetCorrectDateAddForDatabaseType(dbType, "MONTH", "-1")}";
             case AttacherHistoricalDurations.PastYear:
-                return $" WHERE CAST({column} as {dateConvert}) > {GetCorrectDateAddForDatabaseType(dbType, "YEAR", "-1")}";
+                return $" WHERE {column} > {GetCorrectDateAddForDatabaseType(dbType, "YEAR", "-1")}";
             case AttacherHistoricalDurations.SinceLastUse:
-                return loadMetadata.LastLoadTime is not null ? $" WHERE CAST({column} as {dateConvert}) > {ConvertDateString(dbType, loadMetadata.LastLoadTime.GetValueOrDefault().ToString(RemoteTableDateFormat))}" : "";
+                return loadMetadata.LastLoadTime is not null ? $" WHERE {column} > {ConvertDateString(dbType, loadMetadata.LastLoadTime.GetValueOrDefault().ToString(RemoteTableDateFormat))}" : "";
             case AttacherHistoricalDurations.Custom:
                 if (CustomFetchDurationStartDate == DateTime.MinValue && CustomFetchDurationEndDate != DateTime.MinValue)
                 {
                     //end only
-                    return $" WHERE CAST({column} as {dateConvert}) <= {ConvertDateString(dbType, CustomFetchDurationEndDate.ToString(RemoteTableDateFormat))}";
+                    return $" WHERE {column} <= {ConvertDateString(dbType, CustomFetchDurationEndDate.ToString(RemoteTableDateFormat))}";
                 }
 
                 if (CustomFetchDurationStartDate != DateTime.MinValue && CustomFetchDurationEndDate == DateTime.MinValue)
                 {
                     //start only
-                    return $" WHERE CAST({column} as {dateConvert}) >= {ConvertDateString(dbType, CustomFetchDurationStartDate.ToString(RemoteTableDateFormat))}";
+                    return $" WHERE {column} >= {ConvertDateString(dbType, CustomFetchDurationStartDate.ToString(RemoteTableDateFormat))}";
                 }
 
                 if (CustomFetchDurationStartDate == DateTime.MinValue && CustomFetchDurationEndDate == DateTime.MinValue)
@@ -137,12 +138,12 @@ public string SqlHistoricalDataFilter(ILoadMetadata loadMetadata, DatabaseType d
                     return "";
                 }
 
-                return $" WHERE CAST({column} as {dateConvert}) >= {ConvertDateString(dbType, CustomFetchDurationStartDate.ToString(RemoteTableDateFormat))} AND CAST({column} as {dateConvert}) <= {ConvertDateString(dbType, CustomFetchDurationEndDate.ToString(RemoteTableDateFormat))}";
+                return $" WHERE {column} >= {ConvertDateString(dbType, CustomFetchDurationStartDate.ToString(RemoteTableDateFormat))} AND {column} <= {ConvertDateString(dbType, CustomFetchDurationEndDate.ToString(RemoteTableDateFormat))}";
             case AttacherHistoricalDurations.DeltaReading:
                 if (DeltaReadingStartDate == DateTime.MinValue) return "";
                 var startDate = DeltaReadingStartDate.AddDays(-DeltaReadingLookBackDays);
                 var endDate = DeltaReadingStartDate.AddDays(DeltaReadingLookForwardDays);
-                return $" WHERE CAST({column} as {dateConvert}) >= {ConvertDateString(dbType, startDate.ToString(RemoteTableDateFormat))} AND CAST({column} as {dateConvert}) < {ConvertDateString(dbType, endDate.ToString(RemoteTableDateFormat))}";
+                return $" WHERE {column} >= {ConvertDateString(dbType, startDate.ToString(RemoteTableDateFormat))} AND {column} < {ConvertDateString(dbType, endDate.ToString(RemoteTableDateFormat))}";
             default:
                 return "";
         }