Skip to content

Fix #3948 - Changing state was also causing change of initial value #3949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 10, 2024
Merged

Fix #3948 - Changing state was also causing change of initial value #3949

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
16b9673
Fix #3948 - Changing state was also causing change of initial value
DeveloperRaj Jan 30, 2024
6d7d094
Fix review comment and added changeset
DeveloperRaj Apr 10, 2024
4f20104
Merge branch 'main' into fix/nested-field-dirty-issue
DeveloperRaj Apr 10, 2024
d8fde1b
Updated test to check that initial values are not being modified
DeveloperRaj Apr 10, 2024
8434aae
Merge branch 'fix/nested-field-dirty-issue' of https://github.com/Dev…
DeveloperRaj Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packages/formik/src/Formik.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import {
setIn,
setNestedObjectValues,
} from './utils';
import cloneDeep from 'lodash/cloneDeep';

type FormikMessage<Values> =
| { type: 'SUBMIT_ATTEMPT' }
Expand Down Expand Up @@ -173,10 +174,10 @@ export function useFormik<Values extends FormikValues = FormikValues>({

const [, setIteration] = React.useState(0);
const stateRef = React.useRef<FormikState<Values>>({
values: props.initialValues,
errors: props.initialErrors || emptyErrors,
touched: props.initialTouched || emptyTouched,
status: props.initialStatus,
values: cloneDeep(props.initialValues),
errors: cloneDeep(props.initialErrors) || emptyErrors,
touched: cloneDeep(props.initialTouched) || emptyTouched,
status: cloneDeep(props.initialStatus),
isSubmitting: false,
isValidating: false,
submitCount: 0,
Expand Down