ci: revert upload msi to github release #6694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the MSI file upload step from the Windows build workflow for GitHub releases, simplifying the release process by eliminating an unnecessary upload action.
- Removes the conditional MSI upload step that was triggered when the public provider was set to GitHub
Comments suppressed due to low confidence (1)
.github/workflows/template-tauri-build-windows-x64.yml:1
- The step name contains a typo: 'assert' should be 'asset' in 'Upload release assert if public provider is github'.
name: tauri-build-windows-x64
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
louis-jan
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request makes a small change to the Windows build workflow by removing a step that uploaded the MSI release asset to GitHub if the public provider was set to GitHub. This simplifies the release process and reduces unnecessary upload actions.