fix: should not allow duplicating model #6658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request prevents duplicate model IDs when adding new models by implementing validation checks and providing localized error messages to improve user experience.
- Added duplicate model ID validation in the AddModel dialog with error toast notifications
- Added localization support for error messages across 7 language locales
- Integrated the sonner toast library for user-friendly error notifications
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| web-app/src/containers/dialogs/AddModel.tsx | Added duplicate model check with toast error notification |
| web-app/src/locales/*/providers.json | Added translations for model exists error messages |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Barecheck - Code coverage reportTotal: 29.65%Your code coverage diff: 0.00% ▴ |
urmauur
approved these changes
Sep 30, 2025
|
LGTM! 
|
Minh141120
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the user experience when adding a new model by preventing duplicate model IDs and providing localized error messages. The main changes are an added check in the add model dialog to detect existing model IDs and new translations for the error message in multiple languages.
User experience improvements:
DialogAddModel(AddModel.tsx) to prevent users from adding a model with an ID that already exists, displaying an error toast if a duplicate is detected.sonnertoast library to show error notifications in the add model dialog.Localization updates:
modelExists,modelExistsDesc) in English, German, Indonesian, Polish, Vietnamese, Simplified Chinese, and Traditional Chinese locale files. [1] [2] [3] [4] [5] [6] [7]