-
Notifications
You must be signed in to change notification settings - Fork 2.3k
docs: update redirect links #6617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Changes requested ❌
Reviewed everything up to 1dd9adf in 1 minute and 42 seconds. Click for details.
- Reviewed
28lines of code in1files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. docs/_redirects:127
- Draft comment:
The target URL for '/local-server/data-folder' contains an extra 'desktop' segment. Likely it should be '/docs/desktop/data-folder'. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. docs/_redirects:128
- Draft comment:
The target URL for '/local-server/llama-cpp' appears to have an extra 'desktop' segment. Consider updating it to '/docs/desktop/llama-cpp'. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. docs/_redirects:105
- Draft comment:
The redirect for "/docs/install/macos" points to "/docs/desktop/install/mac". This seems inconsistent with the naming of other OS entries (like "linux" and "windows"). Consider updating the target to "/docs/desktop/install/macos" if this is not intentional. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50% While the comment identifies a real inconsistency in naming, there's precedent in the file for using "mac" (line 40). The inconsistency might be intentional. More importantly, this is a redirects file - the target path is likely matching an actual existing file structure that we can't see. Changing the redirect target without knowing if "/docs/desktop/install/macos" actually exists could break things. I might be underestimating the value of consistent naming in URLs. Also, the existence of "mac" in line 40 might be another mistake that should be fixed. While consistency is valuable, we don't have enough context about the actual file structure to safely recommend this change. The risk of breaking redirects outweighs the benefit of consistent naming. Delete the comment. Without knowledge of the actual file structure, suggesting changes to redirect targets could cause broken links.
Workflow ID: wflow_xvDxRJ4up0lxbtJD
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
|
Preview URL: https://9d5b4228.docs-9ba.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed eeaaf5c in 1 minute and 46 seconds. Click for details.
- Reviewed
20lines of code in1files - Skipped
0files when reviewing. - Skipped posting
6draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. docs/_redirects:53
- Draft comment:
Inconsistent target: '/docs/desktop/built-in/tensorrt-llm' redirects to '/docs'. Should this point to a /docs/desktop path? - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. docs/_redirects:125
- Draft comment:
Typo in target: '/docs/desktop/desktop/data-folder' has a duplicated 'desktop'. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. docs/_redirects:126
- Draft comment:
Typo in target: '/docs/desktop/desktop/llama-cpp' contains a duplicated 'desktop'. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. docs/_redirects:64
- Draft comment:
Verify redirect target: '/cortex/vision' points to '/handbook/open-superintelligence' which differs from other docs redirects. Confirm if this is intentional. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
5. docs/_redirects:67
- Draft comment:
Confirm intended behavior: '/docs/threads' redirects to a specific changelog entry. Should this instead point to a documentation page? - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
6. docs/_redirects:54
- Draft comment:
Review target for '/docs/desktop/beta': It currently redirects to '/docs/desktop'. Confirm if the beta segment is meant to be dropped. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%None
Workflow ID: wflow_WWjG6GFwQbVFeqJR
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This pull request adds several new redirects to the
docs/_redirectsfile to ensure that documentation links are correctly routed to their updated locations under the/docs/desktop/path. This helps users find the relevant documentation even if they use older URLs.Documentation redirect updates:
server-settings,settings,llama-cpp-server, installation guides, and multiple example/model pages) to their new locations under/docs/desktop/, ensuring users are directed to the correct updated docs.Important
Adds new redirects in
docs/_redirectsto route old documentation URLs to updated paths under/docs/desktop/.docs/_redirectsfor pages likeserver-settings,settings,llama-cpp-server, installation guides, and various example/model pages./docs/desktop/, ensuring users are directed to the correct documentation.This description was created by
for eeaaf5c. You can customize this summary. It will automatically update as commits are pushed.