-
Notifications
You must be signed in to change notification settings - Fork 2.3k
enhancement: update statistic number jan web #6614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Changes requested ❌
Reviewed everything up to c12bef5 in 2 minutes and 14 seconds. Click for details.
- Reviewed
82lines of code in1files - Skipped
0files when reviewing. - Skipped posting
4draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. docs/src/components/Home/index.tsx:109
- Draft comment:
Reduced top margin from mt-10 to mt-4. Confirm this spacing change aligns with the overall design. - Reason this comment was not posted:
Confidence changes required:10%<= threshold50%None
2. docs/src/components/Home/index.tsx:127
- Draft comment:
Button section: Updated alignment from 'items-center' to 'items-start' and wrapped the DropdownButton with a download stat display. Verify that the alignment works as intended across breakpoints. - Reason this comment was not posted:
Confidence changes required:10%<= threshold50%None
3. docs/src/components/Home/index.tsx:137
- Draft comment:
New download count display added below the DropdownButton. Ensure totalDownload(release) returns the correct formatted value. - Reason this comment was not posted:
Confidence changes required:10%<= threshold50%None
4. docs/src/components/Home/index.tsx:207
- Draft comment:
Floating robot image repositioned: The class changed from 'bottom-0' to '-bottom-10'. Verify that this new positioning works well on all screen sizes. - Reason this comment was not posted:
Confidence changes required:10%<= threshold50%None
Workflow ID: wflow_qUxFOFSAxBEdOWYR
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
|
Preview URL: https://ead73bf9.docs-9ba.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed d1c8cd2 in 36 seconds. Click for details.
- Reviewed
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. docs/src/components/Home/index.tsx:98
- Draft comment:
Good improvement: you now dynamically generate the GitHub releases URL usinglastVersion. Ensure thatlastVersionis always defined (or provide a fallback) to avoid broken links. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_4Ubzwx4dFqBO8GpW
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Describe Your Changes
This pull request updates the homepage UI in
docs/src/components/Home/index.tsxwith minor layout adjustments and changes to how Discord presence and download statistics are displayed. The most important changes are grouped below:UI and Layout Improvements:
mt-10tomt-4for a more compact look.bottom-0to-bottom-10.Statistics Display Changes:
15k+value in multiple places, commenting out the previous dynamic code for future reference. [1] [2] [3]Fixes Issues
Self Checklist
Important
Update homepage UI in
index.tsxwith layout adjustments and static display of Discord presence and download statistics.mt-10tomt-4inindex.tsxfor compactness.bottom-0to-bottom-10.15k+in three places, commented out dynamic code.This description was created by
for d1c8cd2. You can customize this summary. It will automatically update as commits are pushed.