feat: add cleanup logic for windows installer #6578
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the installer cleanup process in the Windows NSIS hooks script. The main focus is on ensuring that unnecessary files are removed from the installation directories after they have been copied to their final locations.
Important
Add cleanup logic to
hooks.nshfor removing unnecessary files post-installation in Windows installer.hooks.nsh, delete$INSTDIR\resources\LICENSEafter copying to$INSTDIR\LICENSE.$INSTDIR\resources\lib\vulkan-1.dllafter copying to$INSTDIR\vulkan-1.dll.$INSTDIR\resources\libdirectory if empty after deletions.DetailPrintmessages for successful deletions and missing files.This description was created by
for 9568ff1. You can customize this summary. It will automatically update as commits are pushed.