Skip to content

Conversation

@Minh141120
Copy link
Member

@Minh141120 Minh141120 commented Sep 24, 2025

This pull request introduces improvements to the installer cleanup process in the Windows NSIS hooks script. The main focus is on ensuring that unnecessary files are removed from the installation directories after they have been copied to their final locations.


Important

Add cleanup logic to hooks.nsh for removing unnecessary files post-installation in Windows installer.

  • Cleanup Logic:
    • In hooks.nsh, delete $INSTDIR\resources\LICENSE after copying to $INSTDIR\LICENSE.
    • Delete $INSTDIR\resources\lib\vulkan-1.dll after copying to $INSTDIR\vulkan-1.dll.
    • Remove $INSTDIR\resources\lib directory if empty after deletions.
  • Logging:
    • Add DetailPrint messages for successful deletions and missing files.

This description was created by Ellipsis for 9568ff1. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 9568ff1 in 1 minute and 12 seconds. Click for details.
  • Reviewed 24 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src-tauri/windows/hooks.nsh:47
  • Draft comment:
    Consider adding error checking or logging after deleting the LICENSE file. If the deletion fails (e.g., due to permissions), it might leave unwanted files.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
2. src-tauri/windows/hooks.nsh:58
  • Draft comment:
    Similarly, check or log the result of deleting vulkan-1.dll. Failure to delete may prevent RMDir from removing the directory if it remains non‐empty.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
3. src-tauri/windows/hooks.nsh:47
  • Draft comment:
    Consider refactoring the repeated cleanup logic into a macro or function to reduce code duplication and ease future maintenance.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_C6SREvXyvcF0gmn9

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@Minh141120 Minh141120 merged commit fe05478 into dev Sep 24, 2025
12 of 22 checks passed
@Minh141120 Minh141120 deleted the feat/windows-installer-cleanup branch September 24, 2025 09:12
@github-project-automation github-project-automation bot moved this to QA in Jan Sep 24, 2025
@github-actions github-actions bot added this to the v0.7.0 milestone Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants