Skip to content

Conversation

@Minh141120
Copy link
Member

@Minh141120 Minh141120 commented Sep 24, 2025

This pull request adds additional HTTP security headers to the docs/_headers file to improve caching control and privacy.


Important

Adds cache control headers to docs/_headers for improved HTTP caching and privacy.

  • Headers:
    • Adds Cache-Control: no-store, no-cache, must-revalidate to docs/_headers for improved caching control.
    • Adds Pragma: no-cache to docs/_headers to ensure backward compatibility with HTTP/1.0 caches.

This description was created by Ellipsis for db35d04. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to db35d04 in 42 seconds. Click for details.
  • Reviewed 14 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. docs/_headers:5
  • Draft comment:
    Review if both 'no-store' and 'no-cache' are needed; 'no-store' alone prevents caching. Ensure this aggressive caching policy is intentional for static docs.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
2. docs/_headers:6
  • Draft comment:
    'Pragma: no-cache' is added for legacy HTTP/1.0 support. Confirm that support for older browsers is needed.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
3. docs/_headers:6
  • Draft comment:
    Consider ending the file with a newline to comply with POSIX standards.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_30wbA1KRvvrKlobi

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Contributor

@hiento09 hiento09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Preview URL: https://e1858771.docs-9ba.pages.dev

@Minh141120 Minh141120 merged commit 0cf2ffd into dev Sep 24, 2025
2 checks passed
@Minh141120 Minh141120 deleted the docs/add-cache-control branch September 24, 2025 03:40
@github-project-automation github-project-automation bot moved this to QA in Jan Sep 24, 2025
@github-actions github-actions bot added this to the v0.7.0 milestone Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants