-
Notifications
You must be signed in to change notification settings - Fork 2.3k
feat: add azure as first class provider #6555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 71f684e in 2 minutes and 21 seconds. Click for details.
- Reviewed
177lines of code in5files - Skipped
1files when reviewing. - Skipped posting
5draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/consts/providers.ts:59
- Draft comment:
Azure provider object added. Structure and settings follow existing providers; verify base URL and docs link accuracy. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. web-app/src/containers/dialogs/AddModel.tsx:52
- Draft comment:
Optional chaining added on providerModels access for supportsToolCalls and supportsImages improves null-safety. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. web-app/src/lib/utils.ts:31
- Draft comment:
Azure provider logo added in getProviderLogo ensuring consistent visuals for all providers. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
4. web-app/src/services/providers/tauri.ts:36
- Draft comment:
Optional chaining for supportsToolCalls and supportsImages in Tauri service adds robustness when providerModels data is missing. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
5. web-app/src/services/providers/web.ts:94
- Draft comment:
Optional chaining and improved error handling in WebProvidersService enhance safety and clarity in model fetch logic. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_y7MrZq1LFzCrAjyw
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Barecheck - Code coverage reportTotal: 30.39%Your code coverage diff: 0.11% ▴ Uncovered files and lines
|
Minh141120
approved these changes
Sep 23, 2025
dinhlongviolin1
added a commit
that referenced
this pull request
Sep 23, 2025
* ✨ feat: Re-arrange docs as needed * 🔧 chore: re-arrange the folder structure * Add server docs Add server docs * enhancement: migrate handbook and janv2 * Update docs/src/components/ui/dropdown-button.tsx Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> * Update docs/src/pages/_meta.json Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> * chore: update feedback #1 * fix: layout ability model * feat: add azure as first class provider (#6555) * feat: add azure as first class provider * fix: deployment url * Update handbook: restructure content and add new sections - Add betting-on-open-source.mdx and open-superintelligence.mdx - Update handbook index with new structure - Remove outdated handbook sections (growth, happy, history, money, talent, teams, users, why) - Update handbook _meta.json to reflect new structure * chore: fix meta data json * chore: update missing install * fix: Catch local API server various errors (#6548) * fix: Catch local API server various errors * chore: Add tests to cover error catches * fix: LocalAPI server trusted host should accept asterisk (#6551) * feat: support .zip archives for manual backend install (#6534) * feat(llamacpp): support .zip archives for manual backend install * Update Lock Files * Merge pull request #6563 from menloresearch/feat/web-minor-ui-tweak-login feat: tweak login UI --------- Co-authored-by: LazyYuuki <[email protected]> Co-authored-by: nngostuds <[email protected]> Co-authored-by: Faisal Amir <[email protected]> Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> Co-authored-by: Louis <[email protected]> Co-authored-by: eckartal <[email protected]> Co-authored-by: Nghia Doan <[email protected]> Co-authored-by: Roushan Kumar Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Describe Your Changes
This PR adds Azure as a first-class provider where users can specify the base URL and key in settings.
Users accessing the model providers screen will see the Azure provider to specify resource names and deployments (models).

Then they can chat with deployments (models)

Open questions:
Q: Why don't we add a new setting called "service name" instead of letting users edit the Base URL?
A: We can do this, but it's to ensure consistency with other providers. There might be multiple resources, and users may not know how to manually add a new Azure Provider. They can refer to this to create a new Azure OpenAI provider.
Fixes Issues
Self Checklist