fix: prevent relocation to root directories

[louis-jan]

Describe Your Changes

Prevent relocation to root directories.

Disallows users from selecting root-level paths (e.g. C:, /, /mnt) as relocation targets to avoid permission issues, data loss risks, and unintended system-level operations.

This pull request adds safeguards to prevent users from relocating or resetting the data folder to a root directory, improving data safety and user experience. It introduces a utility function to detect root directories across platforms and updates UI messages in multiple languages to inform users of these restrictions.

Core functionality and validation:

• Added a new utility function isRootDir in web-app/src/utils/path.ts to reliably detect root directories on Windows, Mac, and Linux systems.
• Updated web-app/src/routes/settings/general.tsx to:
  • Prevent relocating the data folder to a root directory, showing a localized error message if attempted.
  • Prevent resetting the app if the data folder is set to a root directory, also showing a localized error message.
  • Import the new isRootDir utility.

Localization and user feedback:

• Added new localized error messages for these scenarios in English, Indonesian, Polish, Vietnamese, Simplified Chinese, and Traditional Chinese settings locales. [1] [2] [3] [4] [5] [6]

Fixes Issues

• Closes bug: Jan deletes / moves all data in Data folder path #4988

---

Important

Prevents setting root directories as data folder locations, adding checks in general.tsx and path.ts, with localized error messages.

• Behavior:
  • Prevents setting root directories as data folder locations in general.tsx using isRootDir().
  • Shows localized error messages if root directory is selected.
• Utilities:
  • Adds isRootDir() in path.ts to check for root directories on Windows, Mac, and Linux.
• Localization:
  • Adds error messages for root directory restrictions in settings.json for English, Indonesian, Polish, Vietnamese, Simplified Chinese, and Traditional Chinese.

^{This description was created by for 53e00ca. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Caution

Changes requested ❌

Reviewed everything up to 53e00ca in 2 minutes and 17 seconds. Click for details.

• Reviewed 147 lines of code in 8 files
• Skipped 0 files when reviewing.
• Skipped posting 5 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. web-app/src/utils/path.ts:12

• Draft comment:
  Ensure that IS_WINDOWS is imported or defined; it's referenced here without declaration.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% This is a new file being added, and the code won't compile without IS_WINDOWS being defined. However, this kind of issue would be immediately caught by TypeScript compilation and the build process. According to the rules, we should not comment on issues that would be obviously caught by the build. The missing import could indicate a larger architectural issue about how environment detection is handled in the codebase. Maybe this deserves discussion? No, the rules are clear that we should not comment on issues that would be caught by the build, and a missing import/undefined variable is exactly that kind of issue. Delete this comment as it points out an issue that would be immediately caught by TypeScript compilation and the build process.

2. web-app/src/utils/path.ts:13

• Draft comment:
  Verify that the regex /^[a-zA-Z]:\?$/ handles all Windows drive-root formats (with/without trailing slashes) as expected.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to verify the behavior of a regex pattern, which falls under the rule of not asking the author to confirm or ensure behavior. It doesn't provide a specific suggestion or point out a clear issue with the code.

3. web-app/src/routes/settings/general.tsx:78

• Draft comment:
  Using 'janDataFolder ?? "/"' defaults undefined to '/', which may trigger a false positive root check. Ensure janDataFolder is reliably set.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% The comment has a point - if janDataFolder is undefined, it will default to '/' which would trigger the root directory check. However, looking at the code more carefully, this appears to be intentional defensive programming. We want to prevent resetting if we can't determine the data folder location, so defaulting to '/' and blocking the reset in that case is actually good practice. The comment seems to misunderstand that this is an intentional safety check. The comment could be right that this creates false positives, but what if those "false positives" are actually desired behavior for safety? After considering the safety implications, defaulting to '/' when the folder is undefined appears to be intentional defensive programming to prevent dangerous operations when the data folder location is unknown. The comment should be deleted because it misunderstands that the null coalescing to '/' is intentional defensive programming, not a bug.

4. web-app/src/routes/settings/general.tsx:127

• Draft comment:
  Consider handling the relocation delay more robustly instead of using a hardcoded 1000ms setTimeout.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

5. web-app/src/locales/zh-TW/settings.json:207

• Draft comment:
  Typographical issue: The term "資料檔案夾" is used, whereas the consistent term in the file is "資料夾". Please update to "資料夾".
• Reason this comment was not posted:
  Marked as duplicate.

Workflow ID: wflow_gBw84ntVa5ycRJBH

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[github-actions]

Barecheck - Code coverage report

Total: 30.54%

Your code coverage diff: -0.02% ▾

Uncovered files and lines

File	Lines
web-app/src/routes/settings/general.tsx	52, 56-57, 78-82, 84-85, 96-103, 106-110, 112-117, 120-125, 127-130, 132-145, 147-148, 150-153, 165-166, 249, 254, 259-264, 293-303, 305-306
web-app/src/utils/path.ts	12-14, 16-29