-
Notifications
You must be signed in to change notification settings - Fork 2.3k
docs: update url for gifs and videos #6527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 4694ab8 in 1 minute and 34 seconds. Click for details.
- Reviewed
619lines of code in33files - Skipped
41files when reviewing. - Skipped posting
9draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. docs/src/pages/changelog/2023-12-21-faster-inference-across-platform.mdx:11
- Draft comment:
Possible typo in header title; remove the '=' after 'across' for clarity. - Reason this comment was not posted:
Comment was on unchanged code.
2. docs/src/pages/changelog/2024-11-22-jan-bugs.mdx:11
- Draft comment:
Add a space after the colon in the title for better readability. - Reason this comment was not posted:
Comment was on unchanged code.
3. docs/src/pages/changelog/2024-12-30-jan-new-privacy.mdx:13
- Draft comment:
Changelog content mismatch: The header text refers to v0.5.11 hotfix details instead of the expected v0.5.12 privacy update. - Reason this comment was not posted:
Comment was on unchanged code.
4. docs/src/pages/changelog/2024-11-14-jan-supports-qwen-coder.mdx:11
- Draft comment:
Image filename appears inconsistent with the version; expected 'jan-v0.5.8.gif' for version 0.5.8 instead of 'jan-v0.5-7.gif'. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
5. docs/src/pages/changelog/2024-10-24-jan-stable.mdx:11
- Draft comment:
Header title 'Jan is faster now' is inconsistent with the file’s title; consider updating it to reflect 'Stable, Beta and Nightly versions'. - Reason this comment was not posted:
Comment was on unchanged code.
6. docs/src/pages/post/jan-v1-for-research.mdx:8
- Draft comment:
Consider updating the ogImage to an absolute URL for consistency with other image references. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
7. docs/src/pages/changelog/2024-04-25-llama3-command-r-hugginface.mdx:23
- Draft comment:
Typographical error: The alt text 'HugginFace' appears to be a typo. Consider correcting it to 'Huggingface' for consistency. - Reason this comment was not posted:
Comment was on unchanged code.
8. docs/src/pages/changelog/2024-04-25-llama3-command-r-hugginface.mdx:29
- Draft comment:
Typographical error: The alt text 'Latex' should be capitalized correctly as 'LaTeX' to match standard usage. - Reason this comment was not posted:
Comment was on unchanged code.
9. docs/src/pages/changelog/2024-11-22-jan-bugs.mdx:11
- Draft comment:
There is a minor typographical inconsistency in the title attribute: the string is "Jan v0.5.9 is here:fixing what needed fixing" without a space after the colon, while the subsequent text uses "Jan v0.5.9 is here: fixing what needed fixing". Consider adding a space after the colon in the title attribute for consistency. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_Y0cHTwFEPBFTOT2i
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed 465544c in 41 seconds. Click for details.
- Reviewed
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. docs/src/pages/docs/jan-models/jan-v1.mdx:61
- Draft comment:
Good update: absolute URL ensures the demo gif is reliably loaded. Verify that only GIFs/videos are updated per PR intent (keeping PNGs relative if intended). - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_pqI6KuNChnsy1Oky
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
|
Preview URL: https://1a0ab28b.docs-9ba.pages.dev |
This pull request updates all image references in the changelog documentation to use absolute URLs pointing to the Jan AI documentation CDN, instead of relative local paths. This ensures that images display correctly regardless of where the documentation is hosted.
These changes improve the reliability and portability of the documentation by ensuring that all images are loaded from a consistent, externally hosted source.
Important
Updates changelog documentation image references to use absolute URLs for consistent display across hosting locations.
2023-12-21-faster-inference-across-platform.mdx,2024-01-29-local-api-server.mdx, and2024-02-05-jan-data-folder.mdx... and 20 other files.This description was created by
for 465544c. You can customize this summary. It will automatically update as commits are pushed.