-
Notifications
You must be signed in to change notification settings - Fork 2.3k
chore: update build tauri commands #6518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to b8a3699 in 1 minute and 12 seconds. Click for details.
- Reviewed
30lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. Makefile:89
- Draft comment:
Removed redundant download steps from the build target. Confirm that all necessary downloads are now handled by the Tauri build scripts in package.json. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. package.json:30
- Draft comment:
Added 'yarn download:lib' for win32 and linux builds. Ensure that excluding it for darwin is intentional and that macOS builds don’t require this additional step. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_1CeMSAdCVPmJ6LUI
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed 7c5633c in 1 minute and 11 seconds. Click for details.
- Reviewed
31lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. Makefile:80
- Draft comment:
Removed 'build-and-publish' target. Ensure external scripts/CI referencing this target are updated. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the author to ensure that external scripts or CI configurations are updated due to the removal of a target. This falls under asking the author to ensure something is done, which is against the rules.
2. mise.toml:124
- Draft comment:
Removed [tasks.build-and-publish] from mise.toml. Verify that documentation/CI tasks now use the updated build target. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to verify that documentation/CI tasks use the updated build target after a removal. This is asking for confirmation and verification, which is against the rules.
Workflow ID: wflow_xxbO1DZ347TYCCMh
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Barecheck - Code coverage reportTotal: 32.5%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it
This pull request updates the build process for Tauri applications to ensure the necessary libraries are downloaded as part of the build steps, and simplifies the overall build process by removing redundant download commands from the top-level
Makefile.Build process improvements:
package.jsonto includeyarn download:libfor Windows and Linux, ensuring required libraries are downloaded before building. (package.json, package.jsonL30-R32)Makefileby removing theyarn download:binandyarn download:libsteps from the mainbuildtarget, as these are now handled in the Tauri build scripts. (Makefile, MakefileL89-L90)Important
Update Tauri build process to include necessary library downloads and simplify Makefile by removing redundant commands.
package.jsonto includeyarn download:libfor Windows and Linux, ensuring required libraries are downloaded before building.Makefileby removingyarn download:binandyarn download:libfrom the mainbuildtarget, as these are now handled in Tauri build scripts.This description was created by
for 7c5633c. You can customize this summary. It will automatically update as commits are pushed.