Skip to content

Conversation

@Minh141120
Copy link
Member

@Minh141120 Minh141120 commented Sep 18, 2025

This pull request updates the build process for Tauri applications to ensure the necessary libraries are downloaded as part of the build steps, and simplifies the overall build process by removing redundant download commands from the top-level Makefile.

Build process improvements:

  • Updated the Tauri build scripts in package.json to include yarn download:lib for Windows and Linux, ensuring required libraries are downloaded before building. (package.json, package.jsonL30-R32)
  • Simplified the Makefile by removing the yarn download:bin and yarn download:lib steps from the main build target, as these are now handled in the Tauri build scripts. (Makefile, MakefileL89-L90)

Important

Update Tauri build process to include necessary library downloads and simplify Makefile by removing redundant commands.

  • Build Process Improvements:
    • Updated Tauri build scripts in package.json to include yarn download:lib for Windows and Linux, ensuring required libraries are downloaded before building.
    • Simplified Makefile by removing yarn download:bin and yarn download:lib from the main build target, as these are now handled in Tauri build scripts.

This description was created by Ellipsis for 7c5633c. You can customize this summary. It will automatically update as commits are pushed.

@Minh141120 Minh141120 self-assigned this Sep 18, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to b8a3699 in 1 minute and 12 seconds. Click for details.
  • Reviewed 30 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. Makefile:89
  • Draft comment:
    Removed redundant download steps from the build target. Confirm that all necessary downloads are now handled by the Tauri build scripts in package.json.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. package.json:30
  • Draft comment:
    Added 'yarn download:lib' for win32 and linux builds. Ensure that excluding it for darwin is intentional and that macOS builds don’t require this additional step.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_1CeMSAdCVPmJ6LUI

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed 7c5633c in 1 minute and 11 seconds. Click for details.
  • Reviewed 31 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. Makefile:80
  • Draft comment:
    Removed 'build-and-publish' target. Ensure external scripts/CI referencing this target are updated.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the author to ensure that external scripts or CI configurations are updated due to the removal of a target. This falls under asking the author to ensure something is done, which is against the rules.
2. mise.toml:124
  • Draft comment:
    Removed [tasks.build-and-publish] from mise.toml. Verify that documentation/CI tasks now use the updated build target.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to verify that documentation/CI tasks use the updated build target after a removal. This is asking for confirmation and verification, which is against the rules.

Workflow ID: wflow_xxbO1DZ347TYCCMh

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2025

Barecheck - Code coverage report

Total: 32.5%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it

@Minh141120 Minh141120 merged commit 8cdb021 into dev Sep 22, 2025
20 checks passed
@Minh141120 Minh141120 deleted the chore/update-build-tauri branch September 22, 2025 04:32
@github-actions github-actions bot added this to the v0.7.0 milestone Sep 22, 2025
@github-project-automation github-project-automation bot moved this to QA in Jan Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants