chore: prevent click outside for edit dialog #6493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 6f2a019 in 1 minute and 39 seconds. Click for details.
- Reviewed
350lines of code in5files - Skipped
0files when reviewing. - Skipped posting
7draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/containers/dialogs/AddEditAssistant.tsx:239
- Draft comment:
Good use of onInteractOutside to prevent accidental dialog closure. Inline handler is acceptable. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. web-app/src/containers/dialogs/AddEditMCPServer.tsx:307
- Draft comment:
Reformatted validation check for server type improves readability and consistency. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. web-app/src/containers/dialogs/AddEditMCPServer.tsx:371
- Draft comment:
Adding onInteractOutside to DialogContent prevents unintended dialog closure on outside clicks. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
4. web-app/src/containers/dialogs/EditJsonMCPserver.tsx:61
- Draft comment:
Consistent use of onInteractOutside here prevents accidental dismissals of the JSON editing dialog. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
5. web-app/src/containers/dialogs/ImportVisionModelDialog.tsx:47
- Draft comment:
Refactored validateGgufFile function enhances clarity and consistency. Consider adding a fallback if the validateGgufFile method is unavailable. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
6. web-app/src/containers/dialogs/ImportVisionModelDialog.tsx:309
- Draft comment:
Consistent use of onInteractOutside in DialogContent ensures the dialog remains open on accidental outside clicks. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
7. web-app/src/containers/dialogs/ImportVisionModelDialog.tsx:288
- Draft comment:
useEffect re-validates the MMProj file when modelName changes, ensuring compatibility checks remain current. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_3ZkKgMBzHIdyMS4a
You can customize 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request focuses on improving the robustness of several dialog components in the web application by preventing them from closing when users interact outside the dialog area. Additionally, it includes minor code style and readability improvements in the model import logic. These changes help ensure that users do not accidentally dismiss dialogs and improve maintainability.
Dialog interaction handling:
DialogContentinAddEditAssistant.tsx,AddEditMCPServer.tsx,EditJsonMCPserver.tsx, andImportVisionModelDialog.tsxto prevent closing dialogs when clicking outside by usingonInteractOutsidewithe.preventDefault(). [1] [2] [3] [4]Code style and readability improvements:
ImportVisionModelDialog.tsxto use consistent arrow function formatting and dependency arrays foruseCallback. [1] [2]ImportVisionModelDialog.tsxby formatting function calls and error messages. [1] [2]AddEditMCPServer.tsxfor clarity and consistency.Fixes Issues
Self Checklist
Important
Prevents dialogs from closing on outside click and improves code style in
ImportVisionModelDialog.tsxandAddEditMCPServer.tsx.AddEditAssistant.tsx,AddEditMCPServer.tsx,EditJsonMCPserver.tsx, andImportVisionModelDialog.tsxusingonInteractOutsidewithe.preventDefault().ImportVisionModelDialog.tsxto use consistent arrow function formatting and dependency arrays foruseCallback.ImportVisionModelDialog.tsx.AddEditMCPServer.tsxfor clarity and consistency.This description was created by
for 6f2a019. You can customize this summary. It will automatically update as commits are pushed.