Skip to content

Conversation

@Minh141120
Copy link
Member

@Minh141120 Minh141120 commented Sep 16, 2025

This pull request updates the Windows configuration for the Tauri application by adding new options for the webview installation process. The most important change is the introduction of a silent install mode for the webview component, which improves the user experience during installation.

Windows installer improvements:

  • Added a webviewInstallMode configuration to the Windows settings in tauri.windows.conf.json, enabling silent installation and specifying the use of a download bootstrapper for the webview component.

Important

Adds silent install mode for webview in Tauri Windows configuration using downloadBootstrapper.

  • Windows Installer:
    • Adds webviewInstallMode to tauri.windows.conf.json for silent webview installation.
    • Uses downloadBootstrapper for webview component installation.

This description was created by Ellipsis for 022048f. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 022048f in 59 seconds. Click for details.
  • Reviewed 17 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src-tauri/tauri.windows.conf.json:8
  • Draft comment:
    Ensure new 'webviewInstallMode' config is documented and validated. Confirm 'downloadBootstrapper' with silent mode is supported in installation logic.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the author to ensure that a new configuration is documented and validated, and to confirm support for a specific mode in the installation logic. This seems to be asking for confirmation and ensuring behavior, which violates the rules.

Workflow ID: wflow_gZQUMyH1rRqwvfW1

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@github-actions
Copy link
Contributor

Barecheck - Code coverage report

Total: 29.26%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go go go

@louis-jan
Copy link
Contributor

#6445

@louis-jan louis-jan linked an issue Sep 16, 2025 that may be closed by this pull request
@Minh141120 Minh141120 merged commit e579eed into release/v0.6.10 Sep 16, 2025
17 checks passed
@Minh141120 Minh141120 deleted the chore/embed-webview2-bootstrapper branch September 16, 2025 12:20
@github-project-automation github-project-automation bot moved this to QA in Jan Sep 16, 2025
@github-actions github-actions bot added this to the v0.6.10 milestone Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

bug: Jan 0.6.9 blank window

4 participants