Skip to content

Conversation

@louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Sep 15, 2025

This pull request includes a small cleanup to the scripts/download-bin.mjs script. The change removes redundant code that ensured the existence of the downloads directory, likely because this logic is no longer needed or handled elsewhere.
pre-install folder also removed.


Important

Remove redundant directory creation code in scripts/download-bin.mjs and delete empty .gitkeep file from pre-install.

  • Code Removal:
    • Remove redundant code in scripts/download-bin.mjs that ensured the existence of the downloads directory.
  • File Deletion:
    • Delete empty .gitkeep file from pre-install.

This description was created by Ellipsis for e2bc067. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to e2bc067 in 54 seconds. Click for details.
  • Reviewed 19 lines of code in 2 files
  • Skipped 1 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. pre-install/.gitkeep:1
  • Draft comment:
    Removed .gitkeep file. Confirm that the pre-install folder is no longer needed, as this placeholder is typically kept for empty folder tracking.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. scripts/download-bin.mjs:231
  • Draft comment:
    Removed the redundant check for the 'downloads' directory. This appears safe since downloads are now handled in 'scripts/dist'.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_cgLzOSvYM3oBZk5a

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Contributor

@dinhlongviolin1 dinhlongviolin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome backkk!!!!!!!

@louis-jan louis-jan merged commit 1d36a4a into dev Sep 15, 2025
15 checks passed
@louis-jan louis-jan deleted the chore/remove-unused-directories branch September 15, 2025 03:27
@github-project-automation github-project-automation bot moved this to QA in Jan Sep 15, 2025
@github-actions github-actions bot added this to the v0.6.10 milestone Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants