Skip to content

Conversation

@dinhlongviolin1
Copy link
Contributor

@dinhlongviolin1 dinhlongviolin1 commented Sep 14, 2025

Describe Your Changes

  • Better Auth Management
  • Logs for tool calls parameters
  • Fix model extend for openai-compatible models (models == true -> don't flatten and look for models since it is a boolean)

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

Important

Improves authentication management by introducing a shared service, enhances logging for tool calls, and fixes model handling in specific cases.

  • Authentication:
    • Replaces JanAuthService.getInstance() with getSharedAuthService() in api.ts and index.ts for shared authentication management.
    • Removes initialize() method from JanAuthService in auth.ts.
    • Adds getSharedAuthService() to manage a single instance of JanAuthService across extensions.
  • Logging:
    • Adds logging for tool call parameters in postMessageProcessing() in completion.ts.
  • Model Handling:
    • Fixes model handling in sendCompletion() in completion.ts to skip flattening when models is true.
  • Misc:
    • Conditional rendering of BackendUpdater in __root.tsx based on PlatformFeatures.

This description was created by Ellipsis for a67e9f3. You can customize this summary. It will automatically update as commits are pushed.

@dinhlongviolin1 dinhlongviolin1 self-assigned this Sep 14, 2025
@dinhlongviolin1 dinhlongviolin1 changed the title Fix: Web Services Improvment Fix: Web Services Improvement Sep 14, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to a67e9f3 in 1 minute and 10 seconds. Click for details.
  • Reviewed 190 lines of code in 6 files
  • Skipped 0 files when reviewing.
  • Skipped posting 6 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. extensions-web/src/jan-provider-web/api.ts:6
  • Draft comment:
    Good update: importing getSharedAuthService ensures a shared auth instance. Verify that removal of explicit authService.initialize() in initialize() aligns with global token management.
  • Reason this comment was not posted:
    Confidence changes required: 20% <= threshold 50% None
2. extensions-web/src/mcp-web/index.ts:8
  • Draft comment:
    Using getSharedAuthService and removing the explicit authService.initialize() call in onLoad() is consistent with the new auth design.
  • Reason this comment was not posted:
    Confidence changes required: 10% <= threshold 50% None
3. extensions-web/src/shared/auth.ts:22
  • Draft comment:
    Refactor removes the static singleton and initialize() method in JanAuthService. The new getSharedAuthService() on window provides a shared instance—ensure this suits all environments (e.g., SSR).
  • Reason this comment was not posted:
    Confidence changes required: 20% <= threshold 50% None
4. extensions-web/src/shared/index.ts:2
  • Draft comment:
    Index export updated to include getSharedAuthService; this keeps the shared auth interface consistent.
  • Reason this comment was not posted:
    Confidence changes required: 10% <= threshold 50% None
5. web-app/src/lib/completion.ts:195
  • Draft comment:
    The condition checking 'models[providerName]?.models !== true' prevents unnecessary flattening for openai-compatible providers. Also, added console logs for raw and parsed tool arguments improve debugging.
  • Reason this comment was not posted:
    Confidence changes required: 10% <= threshold 50% None
6. web-app/src/routes/__root.tsx:116
  • Draft comment:
    Wrapping with a feature flag (PlatformFeatures[LOCAL_INFERENCE]) is a good improvement for conditional rendering.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_4mKWshittH8IxvFz

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@github-actions
Copy link
Contributor

Barecheck - Code coverage report

Total: 29.01%

Your code coverage diff: 0.01% ▴

Uncovered files and lines
FileLines
extensions-web/src/jan-provider-web/api.ts6-7, 75, 79-81, 83-88, 90-93, 95-97, 99-100, 102-109, 111-115, 117-132, 134-141, 143, 145-155, 157-160, 162-164, 166-167, 169-170, 172-173, 175-177, 179-180, 183, 185-188, 190-193, 195-203, 205-215, 217-219, 221-231, 233
extensions-web/src/mcp-web/index.ts7-11, 16-19, 21, 24-35, 37-38, 40, 42-47, 49-51, 54-62, 64-65, 67-70, 72-74, 77-80, 82-83, 86-99, 102, 104-109, 111-114, 116, 118-119, 121-131, 133-141, 143-148, 150-156, 158, 160-163, 165, 168-171, 173-177, 180-184, 186-189, 191-197, 199-204, 206-209, 211, 213-219, 221, 223-224, 226-235
extensions-web/src/shared/auth.ts19-20, 22-24, 26-28, 30-42, 44-55, 57-61, 63-65, 67-69, 71-79, 81-83, 85, 88, 91-94, 96-98, 100-105, 107-112, 114-115, 117-121, 123, 126, 129-132, 134-136, 138-140, 142-145, 147, 149-152, 155-158, 161-162, 164-169, 171-176, 178-185, 187-190, 192-197, 199-202, 214-219
extensions-web/src/shared/index.ts1-2
web-app/src/lib/completion.ts74-85, 156-164, 166, 168-169, 171-172, 174, 176, 179-184, 186-192, 194-204, 207-215, 217, 219-234, 236-257, 273-279, 330, 333-338, 340-343, 359-364, 369-370, 372-394, 397-417, 419-422, 424, 426-446, 448-457, 459-473, 475-478
web-app/src/routes/__root.tsx1, 4-25, 30-36, 38-41, 43-51, 54, 57-60, 63-71, 74-78, 80-82, 85-89, 91, 93-95, 98-100, 102-107, 109-113, 115-117, 120-124, 127-131, 133-136, 139, 142-149, 151, 153, 156-160, 162-166, 168-170, 172, 174, 176-180, 182-189, 191, 193-194, 196-199, 201-212, 215-221, 223

@dinhlongviolin1 dinhlongviolin1 merged commit 0771b99 into dev Sep 15, 2025
21 checks passed
@dinhlongviolin1 dinhlongviolin1 deleted the bug/fix-tool-calls branch September 15, 2025 02:08
@github-project-automation github-project-automation bot moved this to QA in Jan Sep 15, 2025
@github-actions github-actions bot added this to the v0.6.10 milestone Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants