-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fix: Web Services Improvement #6452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to a67e9f3 in 1 minute and 10 seconds. Click for details.
- Reviewed
190lines of code in6files - Skipped
0files when reviewing. - Skipped posting
6draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. extensions-web/src/jan-provider-web/api.ts:6
- Draft comment:
Good update: importing getSharedAuthService ensures a shared auth instance. Verify that removal of explicit authService.initialize() in initialize() aligns with global token management. - Reason this comment was not posted:
Confidence changes required:20%<= threshold50%None
2. extensions-web/src/mcp-web/index.ts:8
- Draft comment:
Using getSharedAuthService and removing the explicit authService.initialize() call in onLoad() is consistent with the new auth design. - Reason this comment was not posted:
Confidence changes required:10%<= threshold50%None
3. extensions-web/src/shared/auth.ts:22
- Draft comment:
Refactor removes the static singleton and initialize() method in JanAuthService. The new getSharedAuthService() on window provides a shared instance—ensure this suits all environments (e.g., SSR). - Reason this comment was not posted:
Confidence changes required:20%<= threshold50%None
4. extensions-web/src/shared/index.ts:2
- Draft comment:
Index export updated to include getSharedAuthService; this keeps the shared auth interface consistent. - Reason this comment was not posted:
Confidence changes required:10%<= threshold50%None
5. web-app/src/lib/completion.ts:195
- Draft comment:
The condition checking 'models[providerName]?.models !== true' prevents unnecessary flattening for openai-compatible providers. Also, added console logs for raw and parsed tool arguments improve debugging. - Reason this comment was not posted:
Confidence changes required:10%<= threshold50%None
6. web-app/src/routes/__root.tsx:116
- Draft comment:
Wrapping with a feature flag (PlatformFeatures[LOCAL_INFERENCE]) is a good improvement for conditional rendering. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_4mKWshittH8IxvFz
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
qnixsynapse
approved these changes
Sep 14, 2025
Minh141120
approved these changes
Sep 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Fixes Issues
Self Checklist
Important
Improves authentication management by introducing a shared service, enhances logging for tool calls, and fixes model handling in specific cases.
JanAuthService.getInstance()withgetSharedAuthService()inapi.tsandindex.tsfor shared authentication management.initialize()method fromJanAuthServiceinauth.ts.getSharedAuthService()to manage a single instance ofJanAuthServiceacross extensions.postMessageProcessing()incompletion.ts.sendCompletion()incompletion.tsto skip flattening whenmodelsistrue.BackendUpdaterin__root.tsxbased onPlatformFeatures.This description was created by
for a67e9f3. You can customize this summary. It will automatically update as commits are pushed.