Skip to content

Conversation

@Minh141120
Copy link
Member

@Minh141120 Minh141120 commented Sep 12, 2025

This pull request updates the workflow trigger configuration for the Jan Web Server CI/CD pipelines. The main change is the removal of the paths filter from both the development and production workflow YAML files, which broadens the conditions under which the workflows will run.

Workflow trigger changes:

  • Removed the paths filter from the push and pull_request triggers in .github/workflows/jan-server-web-ci.yml, so the workflow will now run on any change to the dev-web branch, not just specific files or directories.
  • Removed the paths filter from the push trigger in .github/workflows/jan-server-web-cicd-prod.yml, so the workflow will now run on any change to the prod-web branch.

Important

Remove paths filter from CI/CD workflow triggers for broader execution conditions on dev-web and prod-web branches.

  • Workflow Trigger Changes:
    • Removed paths filter from push and pull_request triggers in jan-server-web-ci.yml for dev-web branch.
    • Removed paths filter from push trigger in jan-server-web-cicd-prod.yml for prod-web branch.

This description was created by Ellipsis for 6c93513. You can customize this summary. It will automatically update as commits are pushed.

@Minh141120 Minh141120 merged commit 91e17dc into dev Sep 12, 2025
1 check passed
@Minh141120 Minh141120 deleted the ci/remove-path-for-jan-web branch September 12, 2025 06:44
@github-project-automation github-project-automation bot moved this to QA in Jan Sep 12, 2025
@github-actions github-actions bot added this to the v0.6.10 milestone Sep 12, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Changes requested ❌

Reviewed everything up to 6c93513 in 1 minute and 39 seconds. Click for details.
  • Reviewed 51 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/jan-server-web-ci.yml:6
  • Draft comment:
    Remove the extraneous trailing quote from the branch name; it should be 'dev-web' instead of 'dev-web'.
  • Reason this comment was not posted:
    Marked as duplicate.
2. .github/workflows/jan-server-web-cicd-prod.yml:4
  • Draft comment:
    The removal of the 'paths' filter will trigger jobs on any file change in the branch. Confirm that this broader trigger is intended.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.

Workflow ID: wflow_ggxkx5siOWf2fC40

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

- 'Makefile'
- 'package.json'
- 'Dockerfile'
- dev-web'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be a typo on this line. The branch name is listed as "dev-web'" with an unexpected trailing single quote. Please remove the trailing single quote to correct it.

Suggested change
- dev-web'
- dev-web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants