-
Notifications
You must be signed in to change notification settings - Fork 2.3k
removed cloud api spec update #6406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 9ec8761 in 1 minute and 2 seconds. Click for details.
- Reviewed
192lines of code in1files - Skipped
0files when reviewing. - Skipped posting
4draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/update-cloud-api-spec.yml:1
- Draft comment:
The entire workflow file is removed. Ensure this removal is intentional and that any documentation, integrations, or references to this automated API spec update are updated accordingly. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. .github/workflows/update-cloud-api-spec.yml:4
- Draft comment:
The workflow triggered by multiple events (manual dispatch, scheduled runs, and repository dispatch) is removed. Ensure that any external systems or processes relying on these triggers are adjusted accordingly. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. .github/workflows/update-cloud-api-spec.yml:75
- Draft comment:
The steps handling the API specification update—including generating the spec, checking for changes, committing updates, and optionally creating a pull request—have been removed. Verify that this functionality is either no longer needed or has been replaced elsewhere. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. .github/workflows/update-cloud-api-spec.yml:135
- Draft comment:
The workflow steps for sending notifications and summarizing the API update process have been removed. Confirm that any necessary notification mechanisms are now handled by a different process. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_wwj6uo2T4bQqRhQP
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed aef0538 in 1 minute and 24 seconds. Click for details.
- Reviewed
116lines of code in1files - Skipped
0files when reviewing. - Skipped posting
5draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. website/public/openapi/cloud-openapi.json:3
- Draft comment:
Mixed API version: The file declares 'swagger': '2.0' but later uses OpenAPI 3 keys (servers, components). Use a consistent version. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. website/public/openapi/cloud-openapi.json:4042
- Draft comment:
'consumes' and 'produces' are deprecated in OAS3. Use 'content' objects for request/response bodies. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. website/public/openapi/cloud-openapi.json:1913
- Draft comment:
The POST /v1/mcp endpoint uses an empty request schema ({}); a defined schema would prevent ambiguity. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. website/public/openapi/cloud-openapi.json:3990
- Draft comment:
Inconsistent security naming: 'BearerAuth' is used in securityDefinitions while components use 'bearerAuth'. Use a consistent key. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
5. website/public/openapi/cloud-openapi.json:3453
- Draft comment:
The 'function_call' property in the ChatCompletionRequest lacks an explicit type. Specify its type to avoid ambiguity. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_JbdHkPQ7N689TIdY
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
|
Preview URL Astro Docs: https://8beab3af.astro-docs-14t.pages.dev |
Hotfix for API cloud workflow
Important
Removed cloud API spec update workflow and added new endpoints to Jan Server API specification.
.github/workflows/update-cloud-api-spec.yml, removing the workflow for updating the cloud API specification./jan/v1/mcpendpoint incloud-openapi.jsonfor handling MCP requests with a streamable response./jan/v1/modelsendpoint incloud-openapi.jsonto list available models.app_interfaces_http_routes_jan_v1.Modelandapp_interfaces_http_routes_jan_v1.ModelsResponsedefinitions incloud-openapi.json.This description was created by
for aef0538. You can customize this summary. It will automatically update as commits are pushed.