Skip to content

Conversation

@ramonpzg
Copy link
Contributor

@ramonpzg ramonpzg commented Sep 10, 2025

Hotfix for API cloud workflow


Important

Removed cloud API spec update workflow and added new endpoints to Jan Server API specification.

  • Removal:
    • Deleted .github/workflows/update-cloud-api-spec.yml, removing the workflow for updating the cloud API specification.
  • OpenAPI Specification:
    • Added /jan/v1/mcp endpoint in cloud-openapi.json for handling MCP requests with a streamable response.
    • Added /jan/v1/models endpoint in cloud-openapi.json to list available models.
    • Added app_interfaces_http_routes_jan_v1.Model and app_interfaces_http_routes_jan_v1.ModelsResponse definitions in cloud-openapi.json.

This description was created by Ellipsis for aef0538. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 9ec8761 in 1 minute and 2 seconds. Click for details.
  • Reviewed 192 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/update-cloud-api-spec.yml:1
  • Draft comment:
    The entire workflow file is removed. Ensure this removal is intentional and that any documentation, integrations, or references to this automated API spec update are updated accordingly.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. .github/workflows/update-cloud-api-spec.yml:4
  • Draft comment:
    The workflow triggered by multiple events (manual dispatch, scheduled runs, and repository dispatch) is removed. Ensure that any external systems or processes relying on these triggers are adjusted accordingly.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. .github/workflows/update-cloud-api-spec.yml:75
  • Draft comment:
    The steps handling the API specification update—including generating the spec, checking for changes, committing updates, and optionally creating a pull request—have been removed. Verify that this functionality is either no longer needed or has been replaced elsewhere.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. .github/workflows/update-cloud-api-spec.yml:135
  • Draft comment:
    The workflow steps for sending notifications and summarizing the API update process have been removed. Confirm that any necessary notification mechanisms are now handled by a different process.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_wwj6uo2T4bQqRhQP

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed aef0538 in 1 minute and 24 seconds. Click for details.
  • Reviewed 116 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 5 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. website/public/openapi/cloud-openapi.json:3
  • Draft comment:
    Mixed API version: The file declares 'swagger': '2.0' but later uses OpenAPI 3 keys (servers, components). Use a consistent version.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. website/public/openapi/cloud-openapi.json:4042
  • Draft comment:
    'consumes' and 'produces' are deprecated in OAS3. Use 'content' objects for request/response bodies.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. website/public/openapi/cloud-openapi.json:1913
  • Draft comment:
    The POST /v1/mcp endpoint uses an empty request schema ({}); a defined schema would prevent ambiguity.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. website/public/openapi/cloud-openapi.json:3990
  • Draft comment:
    Inconsistent security naming: 'BearerAuth' is used in securityDefinitions while components use 'bearerAuth'. Use a consistent key.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
5. website/public/openapi/cloud-openapi.json:3453
  • Draft comment:
    The 'function_call' property in the ChatCompletionRequest lacks an explicit type. Specify its type to avoid ambiguity.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_JbdHkPQ7N689TIdY

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@github-actions
Copy link
Contributor

Preview URL Astro Docs: https://8beab3af.astro-docs-14t.pages.dev

@ramonpzg ramonpzg requested a review from Minh141120 September 10, 2025 03:42
@ramonpzg ramonpzg merged commit 18351e3 into dev Sep 10, 2025
1 check passed
@ramonpzg ramonpzg deleted the rp/api-ref-fix branch September 10, 2025 03:52
@github-project-automation github-project-automation bot moved this to QA in Jan Sep 10, 2025
@github-actions github-actions bot added this to the v0.6.10 milestone Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants