-
Notifications
You must be signed in to change notification settings - Fork 2.3k
fix: search hgf repo and downloaded filter #6366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Changes requested ❌
Reviewed everything up to 5f9f766 in 1 minute and 59 seconds. Click for details.
- Reviewed
72lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/routes/hub/index.tsx:207
- Draft comment:
Good: Added condition to avoid triggering a HuggingFace repo search in 'Downloaded Only' mode. This prevents unnecessary network calls when the toggle is active. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, explaining what a change does without suggesting any improvements or asking for clarifications. It doesn't align with the rules for useful comments.
2. web-app/src/routes/hub/index.tsx:223
- Draft comment:
Nice improvement: The duplicate check now includes a comparison of both trimmed model names and developers. This fixes the issue with models by different authors sharing the same name. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, as it praises the improvement without providing any actionable feedback or suggestions. It doesn't align with the rules for useful comments.
Workflow ID: wflow_xsTXGUcp1UMLsAr9
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed 38629af in 1 minute and 21 seconds. Click for details.
- Reviewed
133lines of code in1files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/routes/hub/index.tsx:197
- Draft comment:
Consider wrapping fetchHuggingFaceModel in a useCallback to avoid recreating the function on every render and to ensure it captures the latest values of dependencies (like sources and huggingfaceToken). - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. web-app/src/routes/hub/index.tsx:207
- Draft comment:
Consider adding a cleanup effect to clear addModelSourceTimeoutRef on component unmount to prevent any delayed execution after unmount. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
3. web-app/src/routes/hub/index.tsx:216
- Draft comment:
Double-check that the duplication check using .split('/') and pop is robust for all expected HuggingFace repo URL formats. If model names differ in format, this may lead to false negatives. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_ipq4tCGDsm08Vqln
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.


Describe Your Changes
This pull request updates the model search and filtering logic in the
Hubpage to improve the handling of HuggingFace repository searches and the "Downloaded Only" toggle. The changes ensure that switching between viewing all models and only downloaded models properly resets or re-triggers searches, and that duplicate models are prevented by checking both model name and developer.Improvements to search and filtering behavior:
nullfor consistency.Improvements to duplicate model prevention:
Fixes Issues
Screen.Recording.2025-09-03.at.18.31.25.mp4
Self Checklist
Important
Improves HuggingFace repo search and filtering logic in
Hubcomponent, ensuring proper handling of "Downloaded Only" mode and preventing duplicate models by checking both name and developer.fetchHuggingFaceModel()now only triggers when not in "Downloaded Only" mode.nullwhen switching to "Downloaded Only" mode.fetchHuggingFaceModel().handleSearchChange()to clear previous repo info and conditionally fetch models based onshowOnlyDownloaded.This description was created by
for 38629af. You can customize this summary. It will automatically update as commits are pushed.