fix: handle manual toggle vision for remote model

[urmauur]

Describe Your Changes

This pull request makes improvements to how the application checks and manages model capabilities, specifically the "vision" capability, and refines the UI for editing model capabilities. The main changes involve more accurate detection of model capabilities, better handling of the mmproj flag, and a cleaner UI for editing the vision capability.

Capability detection and handling:

• The logic for setting the hasMmproj flag in ChatInput.tsx now more accurately checks if the selected model has the "vision" capability, ensuring that only models with this capability are flagged appropriately.
• The dependency array for the useEffect hook in ChatInput.tsx is updated to include selectedModel?.capabilities, ensuring the effect runs when model capabilities change.

UI improvements:

• The tooltip and disabled state for the vision capability switch in EditModel.tsx have been removed, resulting in a cleaner and simpler UI for editing model capabilities.

Fixes Issues

step 1 edit manually model -> switch vision into true

step 2 back to conv and check chat input, there should be image icon

• Closes #
• Closes #

Self Checklist

• Added relevant comments, esp in complex areas
• Updated docs (for bug fixes / features)
• Created issues for follow-up changes or refactoring needed

---

Important

Enhances model capability detection and UI for 'vision' capability, improving accuracy and simplifying the interface.

• Capability Detection:
  • ChatInput.tsx: Improved logic for hasMmproj flag to accurately detect 'vision' capability for non-llamacpp models.
  • DropdownModelProvider.tsx: Added checkAndUpdateModelVisionCapability() to update 'vision' capability for llamacpp models.
  • useModelProvider.ts: Updated selectModelProvider() to handle 'vision' capability for llamacpp models.
• UI Improvements:
  • EditModel.tsx: Removed tooltip and disabled state for 'vision' capability switch, simplifying the UI.
  • ChatInput.tsx: Updated tooltip and icon sizes for better UI consistency.

^{This description was created by for 62eb422. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed everything up to 45ba949 in 1 minute and 44 seconds. Click for details.

• Reviewed 64 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 2 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. web-app/src/containers/ChatInput.tsx:106

• Draft comment:
  Good update for mmproj support: the added else-if properly flags models with 'vision'. Be cautious that using selectedModel?.capabilities as a dependency may trigger extra runs if the array reference changes frequently.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

2. web-app/src/containers/dialogs/EditModel.tsx:178

• Draft comment:
  Simplified the vision switch UI by removing the tooltip and disabled state. Confirm that manual toggling is intended and that users have enough cues for this change.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_UKPiBxBHkVJYJpYH

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[github-actions]

Barecheck - Code coverage report

Total: 36.07%

Your code coverage diff: 0.04% ▴

Uncovered files and lines

File	Lines
web-app/src/containers/ChatInput.tsx	88-90, 113-119, 121-123, 139-140, 181-182, 204-206, 213-214, 217-220, 223-233, 236, 238-240, 246, 248, 250-251, 253-257, 260-261, 264, 266-269, 271-275, 277-289, 291-301, 303-312, 314-317, 320-321, 323-326, 329-330, 333-337, 340-341, 343-346, 349-351, 354-356, 359-362, 364-365, 367-371, 373-375, 378-379, 382-384, 386-388, 390-391, 393-394, 396-401, 404-409, 411-415, 451-459, 461-466, 468-470, 472-474, 476-477, 535, 575-589, 605-607, 612-616, 631-635, 650-664, 667-681, 691, 709, 726, 728-731
web-app/src/containers/DropdownModelProvider.tsx	43-50, 53-61, 90-94, 103, 109-111, 113-120, 123-128, 130-138, 147-150, 152-157, 159-160, 163-171, 173-178, 206-215, 218-219, 224-227, 229-232, 237-238, 248, 250-256, 258, 260-262, 265-266, 268-274, 290, 298-305, 307-311, 322-323, 329-332, 335-336, 338, 346-353, 356-361, 363-364, 367-375, 403-405, 418-424, 456-462, 469-471, 476, 478-482, 485-490, 492-502, 504-517, 519-520, 522-523, 528, 533-535, 537, 539-542, 545-561, 563-568, 571, 573, 575-581, 583-593, 595-598, 600-601, 603-607, 609-610, 612, 614
web-app/src/containers/dialogs/EditModel.tsx	1, 9-10, 15-16, 24-25, 33-47, 50-56, 59, 61-62, 65-77, 80, 83-87, 89-90, 93, 95, 98, 101-103, 107-115, 118-129, 131-133, 135-150, 152-168, 170-171, 173-184, 186-187, 189-203, 205-211, 240-243, 245
web-app/src/hooks/useModelProvider.ts	33-38, 40-41, 44-54, 56, 58-65, 67-69, 71-104, 106-136, 138-149, 159-161, 163, 165-167, 170-173, 175-176, 178, 180-182, 184-197, 199-202, 204-209, 215, 230-231, 233-241, 244-246, 249-252, 255-262, 264-276, 278-279

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed 8d06c3a in 1 minute and 8 seconds. Click for details.

• Reviewed 88 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 2 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. web-app/src/containers/ChatInput.tsx:543

• Draft comment:
  Wrapping the file attachment element in a TooltipProvider/Tooltip block is a nice UI clarification. Increasing the container size from 'h-6' to 'h-7' also improves the clickable area. Just verify that the translation key t('visions') clearly communicates its purpose.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 50% <= threshold 50% The comment starts with a purely informative statement about the UI change, which is not allowed. However, it ends with a suggestion to verify the translation key, which is a specific request and could be useful. The comment should be edited to remove the purely informative part and keep the useful suggestion.

2. web-app/src/containers/ChatInput.tsx:607

• Draft comment:
  The update changing container classes from 'h-6' to 'h-7' for interactive icons (including embeddings, web search, and reasoning icons) ensures a more consistent and accessible UI. This consistency across elements improves the overall touch target size.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_y6WGQ98T9FuVUIzn

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[dinhlongviolin1]

LGTM

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed 62eb422 in 1 minute and 26 seconds. Click for details.

• Reviewed 40 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 2 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. web-app/src/containers/DropdownModelProvider.tsx:417

• Draft comment:
  Restricting ModelSetting rendering to 'llamacpp' models is intentional, but confirm that other providers with vision capability don’t need this UI. This condition may hide settings for non-llamacpp models if added in the future.
• Reason this comment was not posted:
  Comment looked like it was already resolved.

2. web-app/src/hooks/useModelProvider.ts:241

• Draft comment:
  The migration code now applies only for 'llamacpp' providers. Ensure that this restriction is deliberate so that non-llamacpp models are not affected if they need similar initialization of settings.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to ensure that the restriction to 'llamacpp' providers is deliberate. This falls under the rule of not asking the author to confirm their intention or ensure behavior is intended. Therefore, this comment should be removed.

Workflow ID: wflow_ZRzWOsYl3B4LsjXj

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}