Skip to content

Conversation

@urmauur
Copy link
Member

@urmauur urmauur commented Aug 22, 2025

Describe Your Changes

This pull request updates the description for the "Offload MMProj" setting in the model services. The new description clarifies that the option offloads the multimodal projection model, rather than just the layers, to the GPU.

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

Important

Update description for offload_mmproj setting in models.ts to clarify it offloads the entire model to GPU.

  • Description Update:
    • In models.ts, update description for offload_mmproj setting from 'Offload multimodal projection layers to GPU' to 'Offload multimodal projection model to GPU'.

This description was created by Ellipsis for 7801f9c. You can customize this summary. It will automatically update as commits are pushed.

@urmauur urmauur added this to the v0.6.9 milestone Aug 22, 2025
@urmauur urmauur self-assigned this Aug 22, 2025
@urmauur urmauur added this to Jan Aug 22, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 7801f9c in 1 minute and 18 seconds. Click for details.
  • Reviewed 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/services/models.ts:492
  • Draft comment:
    Consider updating the fallback branch as well. Currently, the description is updated to 'Offload multimodal projection model to GPU' here, but the localStorage fallback (around L532) still uses 'layers'. Ensure consistent wording across both branches.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_hqlr8UMbq0mcM8Im

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@github-actions
Copy link
Contributor

Barecheck - Code coverage report

Total: 36.04%

Your code coverage diff: 0.00% ▴

Uncovered files and lines
FileLines
web-app/src/services/models.ts137-139, 201, 203-207, 271-279, 283-285, 287-288, 290, 292, 294, 296-302, 305-325, 327-328, 331-340, 425, 443-444, 446-447, 459-463, 465-466, 469-470, 473-476, 478-479, 482, 484-504, 507-512, 514-523, 525, 527-537, 539-553, 555-561, 570-571, 574-581

@urmauur urmauur merged commit 63acb3a into release/v0.6.9 Aug 22, 2025
17 checks passed
@github-project-automation github-project-automation bot moved this to QA in Jan Aug 22, 2025
@urmauur urmauur deleted the fix/copy-mmproj-setting branch August 22, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants