Skip to content

Conversation

@urmauur
Copy link
Member

@urmauur urmauur commented Aug 20, 2025

Describe Your Changes

This pull request makes improvements to the filtering logic and UI rendering in the Hub page of the web app. The main changes include refining how downloaded models are filtered and optimizing the display of the filter dropdown based on user input.

Filtering logic improvements:

  • Updated the filtering process for downloaded models to ensure that only models with available quantized variants are shown. This is done by mapping and then filtering out models with no matching quantized variants.

UI rendering optimizations:

  • Modified the renderFilter function so that the filter dropdown menu is only rendered when the search input is empty, streamlining the user interface.

Fixes Issues

Screenshot 2025-08-20 at 14 15 43

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

Important

Improves filtering logic and UI rendering in Hub to show only models with quantized variants and render filter dropdown based on search input.

  • Filtering Logic:
    • Updated filtering in Hub to show only models with available quantized variants.
    • Filters models by mapping and removing those without matching quantized variants.
  • UI Rendering:
    • Modified renderFilter in index.tsx to render filter dropdown only when search input is empty.

This description was created by Ellipsis for 1ad2907. You can customize this summary. It will automatically update as commits are pushed.

@urmauur urmauur added this to the v0.6.9 milestone Aug 20, 2025
@urmauur urmauur requested a review from louis-jan August 20, 2025 07:18
@urmauur urmauur self-assigned this Aug 20, 2025
@urmauur urmauur added this to Jan Aug 20, 2025
@urmauur urmauur moved this to Needs Review in Jan Aug 20, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 1ad2907 in 1 minute and 9 seconds. Click for details.
  • Reviewed 110 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/routes/hub/index.tsx:148
  • Draft comment:
    Reformatted the downloaded filter chain to improve readability. The logic remains unchanged.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
2. web-app/src/routes/hub/index.tsx:432
  • Draft comment:
    The renderFilter function now conditionally returns the filter dropdown only when searchValue is empty. For clarity and consistency, consider explicitly returning null when searchValue is not empty.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_smxWQxheEP5lG1D6

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@urmauur urmauur merged commit 43ab6df into dev Aug 20, 2025
17 checks passed
@urmauur urmauur deleted the fix/sort-filter-hub branch August 20, 2025 07:36
@github-project-automation github-project-automation bot moved this from Needs Review to QA in Jan Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

bug: sort doesn't work with search for models

3 participants