Skip to content

Conversation

@dinhlongviolin1
Copy link
Contributor

@dinhlongviolin1 dinhlongviolin1 commented Aug 20, 2025

Describe Your Changes

  • Local API server log was not showing, now it should. Just a simple change on the filter on the frontend after the structure have changed on the backend side.

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

Important

Fixes log display in LogsViewer by updating SERVER_LOG_TARGET in logs.tsx.

This description was created by Ellipsis for 39fc386. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 39fc386 in 45 seconds. Click for details.
  • Reviewed 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/routes/local-api-server/logs.tsx:14
  • Draft comment:
    The constant SERVER_LOG_TARGET is updated appropriately to 'app_lib::core::server::proxy' to match the backend changes. Verify that this aligns with all backend logging conventions.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_CYBpuEcMLBunAe5d

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@github-actions
Copy link
Contributor

Barecheck - Code coverage report

Total: 36.96%

Your code coverage diff: 0.00% ▴

Uncovered files and lines
FileLines
web-app/src/routes/local-api-server/logs.tsx1-2, 4-7, 10-12, 14-15, 17-20, 22-27, 30-40, 42-54, 57-62, 65-78, 81-84, 86-93, 95-101, 103-107, 109-111, 113

@Minh141120
Copy link
Member

LGTM!
image

@dinhlongviolin1
Copy link
Contributor Author

Ok i will go ahead and merge this

@dinhlongviolin1 dinhlongviolin1 merged commit 6519327 into dev Aug 20, 2025
17 checks passed
@dinhlongviolin1 dinhlongviolin1 deleted the bug/local-api-server-log branch August 20, 2025 07:13
@github-project-automation github-project-automation bot moved this to QA in Jan Aug 20, 2025
@github-actions github-actions bot added this to the v0.6.9 milestone Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

bug: [DEV] local api server logs windows not showing logs

4 participants