Skip to content

Conversation

@Minh141120
Copy link
Member

@Minh141120 Minh141120 commented Aug 13, 2025

This pull request makes a minor update to the GitHub Actions workflow configuration. The change ensures that the disable_updater input is explicitly compared to the string 'true', making the value passed to the job more predictable and robust.


Important

Explicitly compare disable_updater input to 'true' in jan-tauri-build-nightly.yaml for predictable handling.

  • GitHub Actions Workflow:
    • In .github/workflows/jan-tauri-build-nightly.yaml, the disable_updater input is now explicitly compared to 'true'.
    • This change ensures predictable and robust value handling for the disable_updater input in the build-linux-x64 job.

This description was created by Ellipsis for 156bf82. You can customize this summary. It will automatically update as commits are pushed.

@Minh141120 Minh141120 self-assigned this Aug 13, 2025
@Minh141120 Minh141120 requested a review from hiento09 August 13, 2025 03:28
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 156bf82 in 1 minute and 33 seconds. Click for details.
  • Reviewed 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/jan-tauri-build-nightly.yaml:109
  • Draft comment:
    Using an explicit string comparison ('true') ensures predictability. However, since the input is defined as a boolean, double-check that GitHub always provides it as a string, or consider explicitly converting it (e.g., with fromJSON) to avoid potential type mismatches.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_FNN8I70XhK23wcMb

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@Minh141120 Minh141120 merged commit da31675 into dev Aug 13, 2025
6 checks passed
@Minh141120 Minh141120 deleted the ci/fix-tauri-linux-build branch August 13, 2025 03:35
@github-project-automation github-project-automation bot moved this to QA in Jan Aug 13, 2025
@github-actions github-actions bot added this to the v0.6.8 milestone Aug 13, 2025
ramonpzg pushed a commit that referenced this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants