-
Notifications
You must be signed in to change notification settings - Fork 2.3k
fix: visualize readme content for private repo with HF token #6141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: visualize readme content for private repo with HF token #6141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Changes requested ❌
Reviewed everything up to 1a72a59 in 1 minute and 55 seconds. Click for details.
- Reviewed
62lines of code in1files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/routes/hub/$modelId.tsx:27
- Draft comment:
Ensure import order consistency for new hook imports. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. web-app/src/routes/hub/$modelId.tsx:65
- Draft comment:
Passing 'huggingfaceToken' to fetchHuggingFaceRepo is correct; ensure the function properly handles an undefined token. - Reason this comment was not posted:
Comment looked like it was already resolved.
3. web-app/src/routes/hub/$modelId.tsx:173
- Draft comment:
Adding 'huggingfaceToken' to the dependency array ensures that token changes trigger a re-fetch. Confirm this behavior aligns with your intentions. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to confirm their intention regarding the addition of 'huggingfaceToken' to the dependency array. This violates the rule against asking the author to confirm their intention or ensure behavior is intended.
Workflow ID: wflow_g7oTMplciv6vqT0U
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Barecheck - Code coverage reportTotal: 28.66%Your code coverage diff: -0.02% ▾ Uncovered files and lines
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Changes requested ❌
Reviewed 7b2d043 in 1 minute and 53 seconds. Click for details.
- Reviewed
32lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/routes/hub/$modelId.tsx:160
- Draft comment:
Typographical suggestion: The comment on line 160 could be rephrased for clarity. For example, instead of "There is a weird issue where this HF link will return error when access public repo with auth header", consider "There is a known issue where this Hugging Face link returns an error when accessing a public repository with an authorization header." - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% The comment is about improving clarity of documentation, which is good. However, the original comment is already clear enough to understand the issue. The suggested rephrasing is only marginally better and doesn't add significant value. The rules state we should not make purely informative comments that don't require code changes. The comment does improve the professionalism of the documentation. Poor documentation can lead to maintenance issues down the line. While better documentation is valuable, this change is too minor to justify a PR comment. The original comment effectively communicates the issue. Delete this comment as it suggests only a minor stylistic documentation change that doesn't materially improve understanding.
Workflow ID: wflow_bV7PL9w4SkuRaFTA
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
…visualization-private-repo fix: visualize readme content for private repo with HF token
Describe Your Changes
This PR is to address the issue where model detail in hub does not render private repo README content.
Changes:
Before

After

Fixes Issues
Self Checklist
Important
Use HF token to fetch README content for private repos in
HubModelDetail, ensuring proper rendering.HubModelDetail.fetchRepoinHubModelDetailto includehuggingfaceToken.HubModelDetailto handle private repos.This description was created by
for 7b2d043. You can customize this summary. It will automatically update as commits are pushed.