Skip to content

Conversation

@louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Aug 12, 2025

Describe Your Changes

This PR is to address the issue where model detail in hub does not render private repo README content.

Changes:

  • HF token will be used for the README fetch as well.

Before
CleanShot 2025-08-12 at 12 08 31@2x

After
CleanShot 2025-08-12 at 12 08 17@2x

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

Important

Use HF token to fetch README content for private repos in HubModelDetail, ensuring proper rendering.

  • Behavior:
    • Use HF token for fetching README content in private repos in HubModelDetail.
    • Retry README fetch with Authorization header if initial fetch fails.
  • Functions:
    • Update fetchRepo in HubModelDetail to include huggingfaceToken.
    • Modify README fetch logic in HubModelDetail to handle private repos.

This description was created by Ellipsis for 7b2d043. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Changes requested ❌

Reviewed everything up to 1a72a59 in 1 minute and 55 seconds. Click for details.
  • Reviewed 62 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/routes/hub/$modelId.tsx:27
  • Draft comment:
    Ensure import order consistency for new hook imports.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
2. web-app/src/routes/hub/$modelId.tsx:65
  • Draft comment:
    Passing 'huggingfaceToken' to fetchHuggingFaceRepo is correct; ensure the function properly handles an undefined token.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
3. web-app/src/routes/hub/$modelId.tsx:173
  • Draft comment:
    Adding 'huggingfaceToken' to the dependency array ensures that token changes trigger a re-fetch. Confirm this behavior aligns with your intentions.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to confirm their intention regarding the addition of 'huggingfaceToken' to the dependency array. This violates the rule against asking the author to confirm their intention or ensure behavior is intended.

Workflow ID: wflow_g7oTMplciv6vqT0U

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 12, 2025

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Changes requested ❌

Reviewed 7b2d043 in 1 minute and 53 seconds. Click for details.
  • Reviewed 32 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/routes/hub/$modelId.tsx:160
  • Draft comment:
    Typographical suggestion: The comment on line 160 could be rephrased for clarity. For example, instead of "There is a weird issue where this HF link will return error when access public repo with auth header", consider "There is a known issue where this Hugging Face link returns an error when accessing a public repository with an authorization header."
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% The comment is about improving clarity of documentation, which is good. However, the original comment is already clear enough to understand the issue. The suggested rephrasing is only marginally better and doesn't add significant value. The rules state we should not make purely informative comments that don't require code changes. The comment does improve the professionalism of the documentation. Poor documentation can lead to maintenance issues down the line. While better documentation is valuable, this change is too minor to justify a PR comment. The original comment effectively communicates the issue. Delete this comment as it suggests only a minor stylistic documentation change that doesn't materially improve understanding.

Workflow ID: wflow_bV7PL9w4SkuRaFTA

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@louis-jan louis-jan merged commit 8e22b89 into dev Aug 12, 2025
16 checks passed
@louis-jan louis-jan deleted the fix/detail-HF-and-readme-visualization-private-repo branch August 12, 2025 07:09
@github-project-automation github-project-automation bot moved this to QA in Jan Aug 12, 2025
@github-actions github-actions bot added this to the v0.6.8 milestone Aug 12, 2025
ramonpzg pushed a commit that referenced this pull request Aug 15, 2025
…visualization-private-repo

fix: visualize readme content for private repo with HF token
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants