fix: factory reset process got blocked

[louis-jan]

Describe Your Changes

This PR resolves the issue preventing users from performing a factory reset while an MCP server is running.

Changes:

1. Stop all MCP servers before performing factory reset
   2.There should not be any asynchronous event emission for this type of process cleanup.

Fixes Issues

• Closes #
• Closes #

Self Checklist

• Added relevant comments, esp in complex areas
• Updated docs (for bug fixes / features)
• Created issues for follow-up changes or refactoring needed

---

Important

Fixes factory reset blockage by stopping MCP servers before reset and removing async event emissions.

• Behavior:
  • factory_reset in cmd.rs now stops all MCP servers using clean_up_mcp_servers before proceeding.
  • Removed asynchronous event emission for MCP server cleanup.
• Functions:
  • Added clean_up_mcp_servers in mcp.rs to stop and clear MCP servers and restart counts.
  • Removed kill-mcp-servers event listener in setup.rs.
• Misc:
  • Updated on_window_event in lib.rs to use clean_up_mcp_servers directly for cleanup.

^{This description was created by for 9ed9861. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed everything up to 9ed9861 in 1 minute and 8 seconds. Click for details.

• Reviewed 129 lines of code in 4 files
• Skipped 0 files when reviewing.
• Skipped posting 4 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. src-tauri/src/core/cmd.rs:127

• Draft comment:
  Good cleanup ordering in factory_reset: invoking clean_up_mcp_servers before cleanup_processes ensures MCP servers stop before data deletion. Consider logging or handling errors from these cleanup calls.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50% None

2. src-tauri/src/core/mcp.rs:757

• Draft comment:
  In clean_up_mcp_servers, the error from stop_mcp_servers is discarded (using let _ = ...). Consider logging or handling the error to aid debugging if MCP servers fail to stop.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50% None

3. src-tauri/src/core/setup.rs:199

• Draft comment:
  Removal of the kill-mcp-servers event listener is appropriate since cleanup is now directly performed during shutdown and factory reset. Ensure no other part of the application relies on this event.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50% None

4. src-tauri/src/lib.rs:150

• Draft comment:
  Directly invoking clean_up_mcp_servers and cleanup_processes on window close and during RunEvent::Exit avoids async event emission. Using block_in_place to synchronously wait for these async cleanups is acceptable if cleanup is quick; verify that this blocking doesn’t adversely affect shutdown.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_k0OWtZtGj75YtG9N

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[github-actions]

Barecheck - Code coverage report

Total: 28.69%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered