Skip to content

Conversation

@Minh141120
Copy link
Member

@Minh141120 Minh141120 commented Aug 11, 2025

This pull request updates the workflow trigger conditions in .github/workflows/jan-tauri-build-nightly.yaml to make nightly builds run only when relevant files or directories are changed. This helps reduce unnecessary builds and ensures the workflow only runs for meaningful updates.

Workflow configuration improvements:

  • Added a paths filter to the workflow trigger so the nightly build only runs when specific files or directories (such as workflow templates, source code directories, and build scripts) are modified. This includes files like Makefile, package.json, and directories such as src-tauri, core, web-app, extensions, scripts, and pre-install. (.github/workflows/jan-tauri-build-nightly.yaml)

Important

Adds paths filter to .github/workflows/jan-tauri-build-nightly.yaml to trigger builds only on changes to specific files and directories.

  • Workflow Configuration:
    • Adds paths filter to .github/workflows/jan-tauri-build-nightly.yaml to trigger builds only on changes to specific files and directories.
    • Monitors changes in Makefile, package.json, mise.toml, and directories like src-tauri, core, web-app, extensions, scripts, and pre-install.

This description was created by Ellipsis for d5ca195. You can customize this summary. It will automatically update as commits are pushed.

@Minh141120 Minh141120 self-assigned this Aug 11, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to d5ca195 in 1 minute and 55 seconds. Click for details.
  • Reviewed 28 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/jan-tauri-build-nightly.yaml:19
  • Draft comment:
    Paths filter added for pull_request events to trigger builds only on relevant file changes. Confirm this behavior is intended, as schedule and workflow_dispatch triggers are unaffected.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. .github/workflows/jan-tauri-build-nightly.yaml:34
  • Draft comment:
    Ensure new file paths (e.g. 'mise.toml') are kept up to date with project structure changes.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
3. .github/workflows/jan-tauri-build-nightly.yaml:25
  • Draft comment:
    Possible typo detected: The filename 'template-noti-discord-and-update-url-readme.yml' might be intended to be 'template-notify-discord-and-update-url-readme.yml'. Please verify the intended naming.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% The shortened form 'noti' appears to be an intentional abbreviation, not a typo. The file is referenced and used in the workflow, so it must exist and work. The comment is speculative and not based on actual evidence of a problem. Making this change would require renaming a file that appears to be working fine. The file might actually be misnamed and the shortened form could be inconsistent with naming conventions in the broader codebase. Even if there are inconsistent naming conventions, this is working code and the comment is purely speculative without evidence of an actual problem. The comment violates the rule about not making speculative suggestions. Delete this comment as it's speculative, not based on evidence of an actual problem, and the current naming appears to be intentional and functional.
4. .github/workflows/jan-tauri-build-nightly.yaml:34
  • Draft comment:
    Typographical check: The file 'mise.toml' appears in the paths list. Please confirm that 'mise.toml' is spelled correctly and is the intended filename.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to confirm the spelling of a filename, which is not a specific code suggestion or a request for a test. It falls under the category of asking the author to confirm their intention, which is against the rules.

Workflow ID: wflow_fgE8loQKuMWYPVDZ

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Contributor

@hiento09 hiento09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Minh141120 Minh141120 merged commit a75b9c5 into dev Aug 11, 2025
11 checks passed
@Minh141120 Minh141120 deleted the ci/add-path-tauri-nightly-build branch August 11, 2025 14:01
@github-project-automation github-project-automation bot moved this to QA in Jan Aug 11, 2025
@github-actions github-actions bot added this to the v0.6.8 milestone Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants