Skip to content

Conversation

@Minh141120
Copy link
Member

@Minh141120 Minh141120 commented Aug 11, 2025

This pull request updates the deployment and release workflow configurations for documentation and Tauri builds. The main changes improve release note generation and expand production deployment triggers, while also removing redundant steps from the Tauri build workflow.

Release workflow improvements:

  • Enabled automatic generation of release notes for Tauri releases by adding generate_release_notes: true to the release creation step in .github/workflows/jan-tauri-build.yaml.

Deployment workflow enhancements:

  • Updated the Cloudflare Pages production deployment trigger in .github/workflows/jan-docs.yml to also allow deployments when a workflow is manually dispatched from any release/* branch, in addition to the existing conditions.

Workflow simplification:

  • Removed the entire update_release_draft job from .github/workflows/jan-tauri-build.yaml, eliminating the use of the release-drafter action and associated permissions for drafting release notes.

Important

Update workflows to enhance release note generation and deployment triggers, and simplify Tauri build process.

  • Release Workflow Improvements:
    • Enable automatic release note generation for Tauri releases by adding generate_release_notes: true in jan-tauri-build.yaml.
  • Deployment Workflow Enhancements:
    • Update Cloudflare Pages production deployment trigger in jan-docs.yml to allow deployments from release/* branches when manually dispatched.
  • Workflow Simplification:
    • Remove update_release_draft job from jan-tauri-build.yaml, eliminating release-drafter action and associated permissions.

This description was created by Ellipsis for 1563a41. You can customize this summary. It will automatically update as commits are pushed.

@Minh141120 Minh141120 requested a review from hiento09 August 11, 2025 07:49
@Minh141120 Minh141120 self-assigned this Aug 11, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 1563a41 in 1 minute and 4 seconds. Click for details.
  • Reviewed 57 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/jan-docs.yml:79
  • Draft comment:
    The added condition for manual dispatch on release branches (using startsWith with 'refs/heads/release/') looks intentional. Ensure that all release branches follow the naming convention so that deployments trigger as expected.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. .github/workflows/jan-tauri-build.yaml:35
  • Draft comment:
    Adding 'generate_release_notes: true' in the release creation step is a good move. Confirm that the action (softprops/action-gh-release) supports this parameter as expected.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
3. .github/workflows/jan-tauri-build.yaml:119
  • Draft comment:
    The removal of the 'update_release_draft' job simplifies the workflow by eliminating duplicate release draft generation. Verify that no additional customization from the removed job is needed.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_ke2GjZ0sDZZoR6eT

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Contributor

@hiento09 hiento09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Preview URL: https://2efbad55.docs-9ba.pages.dev

Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Minh141120 Minh141120 merged commit 4afabd4 into release/v0.6.8 Aug 11, 2025
12 checks passed
@Minh141120 Minh141120 deleted the ci/update-generate-release-note branch August 11, 2025 08:14
@github-project-automation github-project-automation bot moved this to QA in Jan Aug 11, 2025
@github-actions github-actions bot added this to the v0.6.8 milestone Aug 11, 2025
ramonpzg pushed a commit that referenced this pull request Aug 15, 2025
…e-note

ci: update generate release note and jan docs release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants