-
Notifications
You must be signed in to change notification settings - Fork 2.3k
ci: update generate release note and jan docs release #6121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 1563a41 in 1 minute and 4 seconds. Click for details.
- Reviewed
57lines of code in2files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/jan-docs.yml:79
- Draft comment:
The added condition for manual dispatch on release branches (using startsWith with 'refs/heads/release/') looks intentional. Ensure that all release branches follow the naming convention so that deployments trigger as expected. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. .github/workflows/jan-tauri-build.yaml:35
- Draft comment:
Adding 'generate_release_notes: true' in the release creation step is a good move. Confirm that the action (softprops/action-gh-release) supports this parameter as expected. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. .github/workflows/jan-tauri-build.yaml:119
- Draft comment:
The removal of the 'update_release_draft' job simplifies the workflow by eliminating duplicate release draft generation. Verify that no additional customization from the removed job is needed. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_ke2GjZ0sDZZoR6eT
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Preview URL: https://2efbad55.docs-9ba.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…e-note ci: update generate release note and jan docs release
This pull request updates the deployment and release workflow configurations for documentation and Tauri builds. The main changes improve release note generation and expand production deployment triggers, while also removing redundant steps from the Tauri build workflow.
Release workflow improvements:
generate_release_notes: trueto the release creation step in.github/workflows/jan-tauri-build.yaml.Deployment workflow enhancements:
.github/workflows/jan-docs.ymlto also allow deployments when a workflow is manually dispatched from anyrelease/*branch, in addition to the existing conditions.Workflow simplification:
update_release_draftjob from.github/workflows/jan-tauri-build.yaml, eliminating the use of therelease-drafteraction and associated permissions for drafting release notes.Important
Update workflows to enhance release note generation and deployment triggers, and simplify Tauri build process.
generate_release_notes: trueinjan-tauri-build.yaml.jan-docs.ymlto allow deployments fromrelease/*branches when manually dispatched.update_release_draftjob fromjan-tauri-build.yaml, eliminatingrelease-drafteraction and associated permissions.This description was created by
for 1563a41. You can customize this summary. It will automatically update as commits are pushed.