fix: update ux recemmend backend label into desc setting #6088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 5dd42dd in 1 minute and 30 seconds. Click for details.
- Reviewed
127lines of code in3files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/containers/dynamicControllerSetting/DropdownControl.tsx:1
- Draft comment:
Good cleanup: Removed unused tooltip imports and star icon rendering. Ensure that any prop related to 'recommended' is fully deprecated here. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. web-app/src/routes/settings/providers/$providerName.tsx:411
- Draft comment:
Inline extraction of the backend name using .split('/').pop() works but may misbehave if the format changes. Consider adding a comment or refactoring for clarity. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
3. web-app/src/types/modelProviders.d.ts:4
- Draft comment:
Added optional 'recommended' field to ControllerProps. A brief JSDoc note on its expected format would improve clarity. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_RnEYUWAyBGrW8IQD
You can customize 
Barecheck - Code coverage reportTotal: 33.18%Your code coverage diff: -0.01% ▾ Uncovered files and lines
|
qnixsynapse
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request simplifies the
DropdownControlcomponent by removing the recommended option tooltip and instead displays the recommended backend directly in the provider settings details. The changes improve clarity for users by making the recommended backend more visible and reduce unnecessary UI complexity in the dropdown.UI simplification and clarity:
DropdownControldropdown menu, eliminating extra UI elements and related imports. [1] [2]recommendedprop from theDropdownControlcomponent, streamlining its props.Improved recommended backend visibility:
Fixes Issues
Self Checklist
Important
Simplifies UI by removing recommended option tooltip from dropdown and displaying recommended backend in provider settings.
DropdownControl.tsx.recommendedprop fromDropdownControl.$providerName.tsx.recommendedfield toControllerPropsinmodelProviders.d.ts.This description was created by
for 5dd42dd. You can customize this summary. It will automatically update as commits are pushed.