-
Notifications
You must be signed in to change notification settings - Fork 2.3k
refactor: clean up cortex #6003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 78f8a0d in 1 minute and 37 seconds. Click for details.
- Reviewed
263lines of code in12files - Skipped
0files when reviewing. - Skipped posting
12draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. extensions/assistant-extension/src/@types/global.d.ts:3
- Draft comment:
Removed the obsolete 'CORTEX_API_URL' declaration. Ensure no references remain in other parts of the code. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. extensions/conversational-extension/rolldown.config.mjs:7
- Draft comment:
Removed the API_URL define block from build config; this cleans up unused cortex settings. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, explaining what was done without providing any actionable feedback or suggestions. It doesn't ask for confirmation or suggest any improvements.
3. extensions/conversational-extension/src/@types/global.d.ts:1
- Draft comment:
Deleted the global API_URL declaration; verify that no components rely on this obsolete constant. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to verify that no components rely on a deleted constant, which is against the rules. It is not making a specific suggestion or pointing out a specific issue.
4. src-tauri/src/lib.rs:142
- Draft comment:
Removed the Cortex HTTP delete call via reqwest. Confirm that cleanup_processes now handles required teardown. - Reason this comment was not posted:
Comment looked like it was already resolved.
5. web-app/src/containers/dialogs/CortexFailureDialog.tsx:1
- Draft comment:
Deleted the CortexFailureDialog component; ensure that its removal does not affect error handling flows. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
6. web-app/src/locales/de-DE/common.json:257
- Draft comment:
Removed translations for 'cortexFailureDialog'; verify that no remaining UI elements reference these keys. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the author to verify that no UI elements reference the removed translations. This is a request for verification, which violates the rule against asking the author to confirm or verify things.
7. web-app/src/locales/en/common.json:258
- Draft comment:
Removed Cortex failure translation keys; ensure consistency across localization files. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the author to ensure consistency across localization files after removing certain keys. This is a general request to ensure consistency, which falls under the rule of not asking the author to ensure something is done. It doesn't provide a specific suggestion or point out a specific issue.
8. web-app/src/locales/id/common.json:250
- Draft comment:
Removed cortex-related translation entries; confirm that removed keys are not used anywhere else. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment asks the PR author to confirm that removed keys are not used elsewhere, which violates the rule against asking for confirmation or verification. It does not provide a specific suggestion or point out a specific issue with the code.
9. web-app/src/locales/vn/common.json:250
- Draft comment:
Removed Cortex failure dialog translations; ensure no UI component still refers to these keys. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the author to ensure that no UI component still refers to the removed translation keys. This is a request for confirmation, which violates the rule against asking the author to confirm or ensure things. Therefore, this comment should be removed.
10. web-app/src/locales/zh-CN/common.json:250
- Draft comment:
Removed Cortex-related translation block; check that the UI no longer needs these strings. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the author to check if the UI still needs the removed strings. This is a request for confirmation, which violates the rule against asking the author to confirm their intention or to double-check things.
11. web-app/src/locales/zh-TW/common.json:250
- Draft comment:
Removed Cortex failure dialog translations consistent with other locale files. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, stating what was done without providing any actionable feedback or suggestions. It doesn't ask for confirmation or suggest any improvements.
12. web-app/src/routes/__root.tsx:167
- Draft comment:
Removed the import and usage of CortexFailureDialog from the root layout; review that error reporting does not miss any cortex-related issues. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the author to review the error reporting after a specific change. It is not making a specific suggestion or pointing out a specific issue with the code. This violates the rule against asking the author to ensure behavior is intended or to double-check things.
Workflow ID: wflow_ZLE2hAsmLcBjAJJi
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Barecheck - Code coverage reportTotal: 38.76%Your code coverage diff: 0.15% ▴ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed 4e09b7f in 47 seconds. Click for details.
- Reviewed
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src-tauri/src/core/mcp.rs:260
- Draft comment:
The doc comment now omits the reference to 'cortex restart', which cleans up the description and avoids exposing internal details. This change is purely cosmetic and looks good. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_KMoDp6ab95Wm6m15
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
4e09b7f to
860dcfd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed 5b5f678 in 1 minute and 12 seconds. Click for details.
- Reviewed
20lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src-tauri/src/lib.rs:167
- Draft comment:
Removed HTTP shutdown call. Ensure the HTTP server is properly terminated elsewhere, if needed. Verify that cleanup_processes covers all necessary cleanup to avoid orphaned processes. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_d0trusUzywNTqZme
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Describe Your Changes
Some of the cortex stuff still left. This is to clean it up.
Fixes Issues
Self Checklist
Important
Refactor to remove Cortex-related code, configurations, and translations, and update MCP server handling logic.
CortexFailureDialogcomponent from__root.tsxand deleteCortexFailureDialog.tsx.CORTEX_API_URLfromglobal.d.tsinassistant-extension.API_URLfromglobal.d.tsinconversational-extension.rolldown.config.mjs.start_mcp_server_with_restart()inmcp.rsto remove Cortex-specific comments.lib.rs.common.jsonin multiple locales.This description was created by
for 5b5f678. You can customize this summary. It will automatically update as commits are pushed.