Skip to content

Conversation

@louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Jul 31, 2025

Describe Your Changes

Some of the cortex stuff still left. This is to clean it up.

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

Important

Refactor to remove Cortex-related code, configurations, and translations, and update MCP server handling logic.

  • Code Removal:
    • Remove CortexFailureDialog component from __root.tsx and delete CortexFailureDialog.tsx.
    • Remove CORTEX_API_URL from global.d.ts in assistant-extension.
    • Remove API_URL from global.d.ts in conversational-extension.
    • Remove Cortex-related API URL definition from rolldown.config.mjs.
  • Code Refactoring:
    • Update start_mcp_server_with_restart() in mcp.rs to remove Cortex-specific comments.
    • Remove HTTP client code related to Cortex in lib.rs.
  • Localization:
    • Remove Cortex failure dialog translations from common.json in multiple locales.

This description was created by Ellipsis for 5b5f678. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 78f8a0d in 1 minute and 37 seconds. Click for details.
  • Reviewed 263 lines of code in 12 files
  • Skipped 0 files when reviewing.
  • Skipped posting 12 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. extensions/assistant-extension/src/@types/global.d.ts:3
  • Draft comment:
    Removed the obsolete 'CORTEX_API_URL' declaration. Ensure no references remain in other parts of the code.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. extensions/conversational-extension/rolldown.config.mjs:7
  • Draft comment:
    Removed the API_URL define block from build config; this cleans up unused cortex settings.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, explaining what was done without providing any actionable feedback or suggestions. It doesn't ask for confirmation or suggest any improvements.
3. extensions/conversational-extension/src/@types/global.d.ts:1
  • Draft comment:
    Deleted the global API_URL declaration; verify that no components rely on this obsolete constant.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to verify that no components rely on a deleted constant, which is against the rules. It is not making a specific suggestion or pointing out a specific issue.
4. src-tauri/src/lib.rs:142
  • Draft comment:
    Removed the Cortex HTTP delete call via reqwest. Confirm that cleanup_processes now handles required teardown.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
5. web-app/src/containers/dialogs/CortexFailureDialog.tsx:1
  • Draft comment:
    Deleted the CortexFailureDialog component; ensure that its removal does not affect error handling flows.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
6. web-app/src/locales/de-DE/common.json:257
  • Draft comment:
    Removed translations for 'cortexFailureDialog'; verify that no remaining UI elements reference these keys.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the author to verify that no UI elements reference the removed translations. This is a request for verification, which violates the rule against asking the author to confirm or verify things.
7. web-app/src/locales/en/common.json:258
  • Draft comment:
    Removed Cortex failure translation keys; ensure consistency across localization files.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the author to ensure consistency across localization files after removing certain keys. This is a general request to ensure consistency, which falls under the rule of not asking the author to ensure something is done. It doesn't provide a specific suggestion or point out a specific issue.
8. web-app/src/locales/id/common.json:250
  • Draft comment:
    Removed cortex-related translation entries; confirm that removed keys are not used anywhere else.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment asks the PR author to confirm that removed keys are not used elsewhere, which violates the rule against asking for confirmation or verification. It does not provide a specific suggestion or point out a specific issue with the code.
9. web-app/src/locales/vn/common.json:250
  • Draft comment:
    Removed Cortex failure dialog translations; ensure no UI component still refers to these keys.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the author to ensure that no UI component still refers to the removed translation keys. This is a request for confirmation, which violates the rule against asking the author to confirm or ensure things. Therefore, this comment should be removed.
10. web-app/src/locales/zh-CN/common.json:250
  • Draft comment:
    Removed Cortex-related translation block; check that the UI no longer needs these strings.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the author to check if the UI still needs the removed strings. This is a request for confirmation, which violates the rule against asking the author to confirm their intention or to double-check things.
11. web-app/src/locales/zh-TW/common.json:250
  • Draft comment:
    Removed Cortex failure dialog translations consistent with other locale files.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, stating what was done without providing any actionable feedback or suggestions. It doesn't ask for confirmation or suggest any improvements.
12. web-app/src/routes/__root.tsx:167
  • Draft comment:
    Removed the import and usage of CortexFailureDialog from the root layout; review that error reporting does not miss any cortex-related issues.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the author to review the error reporting after a specific change. It is not making a specific suggestion or pointing out a specific issue with the code. This violates the rule against asking the author to ensure behavior is intended or to double-check things.

Workflow ID: wflow_ZLE2hAsmLcBjAJJi

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2025

Barecheck - Code coverage report

Total: 38.76%

Your code coverage diff: 0.15% ▴

Uncovered files and lines
FileLines
web-app/src/routes/__root.tsx1, 4-24, 29-31, 33-36, 38-46, 49, 52-55, 58-66, 68-72, 74-75, 78-82, 85-89, 91-94, 97, 100-107, 109, 111, 114-118, 120-124, 126-128, 130, 132-136, 138-145, 147, 149-150, 152-155, 157-167, 169-173, 175

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed 4e09b7f in 47 seconds. Click for details.
  • Reviewed 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src-tauri/src/core/mcp.rs:260
  • Draft comment:
    The doc comment now omits the reference to 'cortex restart', which cleans up the description and avoids exposing internal details. This change is purely cosmetic and looks good.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_KMoDp6ab95Wm6m15

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@louis-jan louis-jan force-pushed the refactor/clean-up-cortex branch from 4e09b7f to 860dcfd Compare July 31, 2025 14:36
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed 5b5f678 in 1 minute and 12 seconds. Click for details.
  • Reviewed 20 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src-tauri/src/lib.rs:167
  • Draft comment:
    Removed HTTP shutdown call. Ensure the HTTP server is properly terminated elsewhere, if needed. Verify that cleanup_processes covers all necessary cleanup to avoid orphaned processes.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_d0trusUzywNTqZme

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@louis-jan louis-jan merged commit 9c0d09c into dev Jul 31, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this to QA in Jan Jul 31, 2025
@louis-jan louis-jan deleted the refactor/clean-up-cortex branch July 31, 2025 14:58
@github-actions github-actions bot added this to the v0.6.7 milestone Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants