-
Notifications
You must be signed in to change notification settings - Fork 2.3k
fix: download progress missing when left panel scrollable #5984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to f4fdaaf in 1 minute and 58 seconds. Click for details.
- Reviewed
47lines of code in1files - Skipped
0files when reviewing. - Skipped posting
4draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/containers/LeftPanel.tsx:45
- Draft comment:
Check the import path: 'DownloadManegement' may be a typo of 'DownloadManagement'. If unintentional, consider renaming for clarity. - Reason this comment was not posted:
Comment was on unchanged code.
2. web-app/src/containers/LeftPanel.tsx:172
- Draft comment:
Newly added useDownloadStore hook: Ensure it reliably returns defined values for downloads and localDownloadingModels to avoid any render issues. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
3. web-app/src/containers/LeftPanel.tsx:259
- Draft comment:
Conditional height calculation: Consider extracting the logic (switching between 'h-[calc(100%-200px)]' and 'h-[calc(100%-140px)]') into a variable for improved readability, and verify that removing the '!h-' override does not affect styling specificity. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50% The comment has two parts: 1) Extracting logic to variable - this could improve readability but is a minor improvement 2) Questioning !h- override - but this seems speculative since we don't have full context of CSS specificity needs. The height calculation itself is fairly straightforward and readable as-is. The benefit of extracting it seems minimal. I could be undervaluing the readability benefits of extracting the logic. The !h- override question could be pointing to a real CSS specificity issue. While extraction could help slightly, the current inline logic is clear enough. The !h- specificity concern is too speculative without more context about CSS cascade needs. The comment's suggestions are not compelling enough to justify a code change. The current code is reasonably clear and functional as-is.
4. web-app/src/containers/LeftPanel.tsx:496
- Draft comment:
DownloadManagement component relocation: It is now rendered only once. Double-check its new position (within the bottom menu container) meets the intended UX for always-visible download progress. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to double-check the new position of the DownloadManagement component, which violates the rule against asking the author to confirm their intention or ensure behavior is intended. It does not provide a specific suggestion or point out a clear issue.
Workflow ID: wflow_Yu28VLNKhQ7yzk1W
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
qnixsynapse
approved these changes
Jul 30, 2025
Barecheck - Code coverage reportTotal: 38.63%Your code coverage diff: 0.02% ▴ |
louis-jan
approved these changes
Jul 30, 2025
|
Tested build 979 on Mac cc @Minh141120 Screen.Recording.2025-07-30.at.18.29.03.mp4 |
Minh141120
approved these changes
Jul 30, 2025
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Describe Your Changes
This pull request enhances the
LeftPanelcomponent in theweb-appby integrating download state management and dynamically adjusting the layout based on download activity. The most important changes include adding theuseDownloadStorehook, updating the layout to reflect download activity, and ensuring proper rendering of theDownloadManagementcomponent.Integration of download state management:
useDownloadStorehook to theLeftPanelcomponent to accessdownloadsandlocalDownloadingModelsstate. (web-app/src/containers/LeftPanel.tsx, [1] [2]Layout adjustments based on download activity:
LeftPanelto dynamically adjust based on whether there are active downloads or local downloading models. (web-app/src/containers/LeftPanel.tsx, web-app/src/containers/LeftPanel.tsxL256-R266)Rendering improvements:
DownloadManagementcomponent is properly rendered within theLeftPanelstructure. (web-app/src/containers/LeftPanel.tsx, web-app/src/containers/LeftPanel.tsxL489-R501)Fixes Issues
Screen.Recording.2025-07-30.at.18.11.26.mp4
Self Checklist
Important
Enhances
LeftPanelby integrating download state management and adjusting layout based on download activity.useDownloadStorehook inLeftPanelto managedownloadsandlocalDownloadingModelsstate.LeftPanelbased on active downloads or local downloading models.DownloadManagementcomponent is properly rendered withinLeftPanel.This description was created by
for f4fdaaf. You can customize this summary. It will automatically update as commits are pushed.