Skip to content

Conversation

@cmppoon
Copy link
Contributor

@cmppoon cmppoon commented Jul 29, 2025

Describe Your Changes

Hello maintainers,

I came across #5923 and I would like to contribute by fixing this issue.

  • I noticed that the local updated field is not updated when performing actions, which causes the sorting logic not to trigger as expected.

I hope this fix is correct and helpful. Let me know if there is any changes required from my end. Thanks!

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

Important

Fixes thread sorting issue by updating updated timestamp in useThreads.ts functions.

  • Behavior:
    • Fixes thread sorting issue by updating updated timestamp in toggleFavorite, updateCurrentThreadAssistant, and renameThread in useThreads.ts.
    • Ensures sorting logic triggers correctly when threads are modified.
  • Fixes:

This description was created by Ellipsis for 1b330ef. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 1b330ef in 56 seconds. Click for details.
  • Reviewed 28 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/hooks/useThreads.ts:91
  • Draft comment:
    Good: 'updated' field is now set in toggleFavorite. Consider using Math.floor(Date.now() / 1000) if an integer timestamp is preferred.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
2. web-app/src/hooks/useThreads.ts:190
  • Draft comment:
    Nice update: refreshing the timestamp in updateCurrentThreadAssistant to aid immediate sorting.
  • Reason this comment was not posted:
    Confidence changes required: 10% <= threshold 50% None
3. web-app/src/hooks/useThreads.ts:219
  • Draft comment:
    Setting 'updated' in renameThread ensures threads reorder immediately on title change. This fixes the reported issue.
  • Reason this comment was not posted:
    Confidence changes required: 10% <= threshold 50% None

Workflow ID: wflow_fdx4u0S0fVexUV78

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@urmauur urmauur self-assigned this Jul 30, 2025
@urmauur
Copy link
Member

urmauur commented Jul 30, 2025

Hi @cmppoon, Thank you for contributing. I really appreciate it. we’re going to release version 0.6.6 this week, I think this will be included in version 0.6.7. I’ll try it out first.

@urmauur urmauur added this to the v0.6.7 milestone Jul 30, 2025
@urmauur urmauur force-pushed the fix-thread-sorting-issue branch from 1b330ef to a31d580 Compare July 30, 2025 06:09
Copy link
Member

@urmauur urmauur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@urmauur urmauur merged commit d2f99c3 into janhq:dev Jul 30, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this to QA in Jan Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

bug: Thread sorting order issue

2 participants