Skip to content

Conversation

@qnixsynapse
Copy link
Contributor

@qnixsynapse qnixsynapse commented Jul 28, 2025

Describe Your Changes

The variable was not initialised resulted in always setting true when starting.

This change fixes it.


Important

Initialize autoUnload in onLoad() to use configuration value in index.ts.

  • Behavior:
    • Initialize autoUnload in onLoad() in index.ts to use this.config.auto_unload instead of defaulting to true.
  • Misc:
    • Fixes issue where autoUnload was always set to true on start.

This description was created by Ellipsis for b243012. You can customize this summary. It will automatically update as commits are pushed.

The variable was not initialized resulted in always setting true when
starting.

This change fixes it.
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to b243012 in 1 minute and 0 seconds. Click for details.
  • Reviewed 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. extensions/llamacpp-extension/src/index.ts:171
  • Draft comment:
    Good fix: initializing this.autoUnload from the config ensures it reflects the saved setting rather than always defaulting to true. Consider aligning naming (e.g. auto_unloadautoUnload) if feasible.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.

Workflow ID: wflow_HXCHaXycbYly12JU

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@github-actions
Copy link
Contributor

Barecheck - Code coverage report

Total: 38.73%

Your code coverage diff: 0.01% ▴

✅ All code changes are covered

Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and work great

@qnixsynapse qnixsynapse merged commit 07421d7 into release/v0.6.6 Jul 28, 2025
18 of 21 checks passed
@qnixsynapse qnixsynapse deleted the fix/my_stupidity_x2 branch July 28, 2025 15:24
@github-project-automation github-project-automation bot moved this to QA in Jan Jul 28, 2025
@github-actions github-actions bot added this to the v0.6.7 milestone Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants